Page MenuHomePhabricator
Differential D5777

[web] 1/N Disable 'Delete' button on delete account modal when password input is empty
ClosedPublic
Actions

Authored by • adar on Nov 30 2022, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 7:49 PM
Unknown Object (File)
Fri, Nov 8, 9:58 AM
Unknown Object (File)
Sat, Nov 2, 8:43 PM
Unknown Object (File)
Sat, Nov 2, 8:43 PM
Unknown Object (File)
Sat, Nov 2, 8:43 PM
Unknown Object (File)
Sat, Nov 2, 8:40 PM
Unknown Object (File)
Oct 6 2024, 4:42 PM
Unknown Object (File)
Sep 18 2024, 1:52 PM
View All 80 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
rohan
Commits
rCOMM3ccdba9199ff: [web] 1/N Disable 'Delete' button on delete account modal when password input…
Summary

On web, this disables the delete account button until some input has been entered into the password field
ENG-2014

Test Plan

with no input: button disabled

Screen Shot 2022-11-30 at 2.55.50 PM.png (2×5 px, 480 KB)

with input: button enabled
Screen Shot 2022-11-30 at 2.55.57 PM.png (2×5 px, 478 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• adar created this revision.Nov 30 2022, 11:54 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 30 2022, 11:54 AM
• adar retitled this revision from [web] Disable 'Delete' button on delete account modal when password input is empty to [web] 1/N Disable 'Delete' button on delete account modal when password input is empty.Nov 30 2022, 11:54 AM
• adar edited the summary of this revision. (Show Details)Nov 30 2022, 11:56 AM
• adar edited the test plan for this revision. (Show Details)
• adar removed subscribers: tomek, atul.
• adar added a subscriber: tomek.
Harbormaster completed remote builds in B13891: Diff 19031.Nov 30 2022, 12:04 PM
• adar requested review of this revision.Nov 30 2022, 12:04 PM
ashoat added a comment.Nov 30 2022, 2:54 PM

Please never submit diffs without specifying reviewers

• adar added a reviewer: atul.Nov 30 2022, 5:24 PM
atul added reviewers: ginsu, rohan.Dec 1 2022, 2:08 PM
atul accepted this revision.Dec 1 2022, 2:42 PM

Looks good!

This revision is now accepted and ready to land.Dec 1 2022, 2:42 PM
Closed by commit rCOMM3ccdba9199ff: [web] 1/N Disable 'Delete' button on delete account modal when password input… (authored by • adar). · Explain WhyDec 5 2022, 10:32 AM
This revision was automatically updated to reflect the committed changes.
• adar added a commit: rCOMM3ccdba9199ff: [web] 1/N Disable 'Delete' button on delete account modal when password input….

Revision Contents
Changeset List

PathSize
web/
settings/
4 lines

Diff 19031

View Options

web/settings/account-delete-modal.react.js

Loading...