[web] Disable 'change password' button until text inputs are not empty
ClosedPublic
Actions

Authored by • adar on Dec 1 2022, 7:25 AM.

Details

Reviewers

atul
ginsu
rohan

Commits

rCOMM333cd87889de: [web] Disable 'change password' button until text inputs are not empty

Summary

This diff disables the 'Change password' button within user settings until the user has entered text into each of the input fields on the modal. Linked the the linear task ENG-2014

Test Plan

https://www.loom.com/share/1fd6e9db9f414140a1148dffc0dbad62

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• adar created this revision.Dec 1 2022, 7:25 AM

• adar held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2022, 7:25 AM

• adar edited the summary of this revision. (Show Details)Dec 1 2022, 7:26 AM

Harbormaster completed remote builds in B13916: Diff 19071.Dec 1 2022, 7:38 AM

• adar published this revision for review.Dec 1 2022, 7:44 AM

atul added reviewers: ginsu, rohan.Dec 1 2022, 2:28 PM

Not sure if inputDisabled handles this already, but I feel like we should be doing other checks too for example

new password and confirm new password are the same
current password matches the correct current password

But overall looks good, and I know this wasn't part of the linear task, but might be a good follow-up diff to what we have right now.

atul accepted this revision.Dec 1 2022, 2:43 PM

This revision is now accepted and ready to land.Dec 1 2022, 2:43 PM

ginsu accepted this revision.Dec 1 2022, 2:44 PM

current password matches the correct current password

I don't think we should be doing this validation on the front-end.

new password and confirm new password are the same

We could do this validation before enabling the "Change password" button... but in my experience that check usually happens after the "submit" or "change password" button is pressed.

Closed by commit rCOMM333cd87889de: [web] Disable 'change password' button until text inputs are not empty (authored by • adar). · Explain WhyDec 5 2022, 10:32 AM

This revision was automatically updated to reflect the committed changes.

• adar added a commit: rCOMM333cd87889de: [web] Disable 'change password' button until text inputs are not empty.