[lib] Document why `ClientDBMessageInfo` uses strings everywhere
ClosedPublic
Actions

Authored by atul on Dec 6 2022, 10:30 AM.

Details

Reviewers

tomek
marcin
varun
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM1772c35ca17c: [lib] Document why `ClientDBMessageInfo` uses strings everywhere

Summary

Context: Should close https://linear.app/comm/issue/ENG-237/document-why-clientdbmessageinfo-uses-strings-everywhere

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 6 2022, 10:30 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 10:30 AM

fix

atul added a reviewer: Restricted Owners Package.Dec 6 2022, 10:32 AM

Harbormaster completed remote builds in B14019: Diff 19194.Dec 6 2022, 10:43 AM

atul requested review of this revision.Dec 6 2022, 10:43 AM

Harbormaster completed remote builds in B14018: Diff 19193.Dec 6 2022, 10:43 AM

ashoat accepted this revision.Dec 6 2022, 6:51 PM

This revision is now accepted and ready to land.Dec 6 2022, 6:51 PM

Closed by commit rCOMM1772c35ca17c: [lib] Document why `ClientDBMessageInfo` uses strings everywhere (authored by atul). · Explain WhyDec 7 2022, 11:38 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1772c35ca17c: [lib] Document why `ClientDBMessageInfo` uses strings everywhere.

Revision Contents
Changeset List

Path

Size

lib/

types/

message-types.js

10 lines

Diff 19233

View Options

lib/types/message-types.js

[lib] Document why `ClientDBMessageInfo` uses strings everywhereClosedPublicActions