included RawReactionMessageInfo to RawMessageInfo and ReactionMessageInfo to MessageInfo. We need to do this because unshimMessageInfo uses RawMessageInfo for its type and MessageInfo type is used extensively in chat selectors.
Linear Task: ENG-2244
Details
Details
ran flow in lib, native, and keyserver directories and nothing crashes locally on native/web
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/selectors/chat-selectors.js | ||
|---|---|---|
| 312–314 ↗ | (On Diff #19112) | A subsequent diff will handle what happens if a message is a reaction type and do all the merging magic, but for now, we just want to filter out all the reaction messages from this function |
| keyserver/src/creators/thread-creator.js | ||
|---|---|---|
| 195–198 ↗ | (On Diff #19112) | I don't think we should use invariant. We should stay consistent with other places in the code and throw ServerError when validation fails. |
| keyserver/src/fetchers/message-fetchers.js | ||
| 683–690 ↗ | (On Diff #19112) | It might make sense to merge these invariants. Moreover it might be a good idea to define a set of message types that can't be a sidebar source and use it in all the places. |
| keyserver/src/creators/thread-creator.js | ||
|---|---|---|
| 195 ↗ | (On Diff #19195) | It probably can be simplified |
| lib/shared/messages/sidebar-source-message-spec.js | ||
| 110–117 ↗ | (On Diff #19195) | When addressing a comment please check if there are other instances where the change could be also applied. This is really similar to the other place where invariants got merged. |
| keyserver/src/creators/thread-creator.js | ||
|---|---|---|
| 195 ↗ | (On Diff #19195) | When I tried this, flow was giving me some errors about how there were missing fields in the sourceMessage  |