Page MenuHomePhabricator
Differential D5874

[web] Update thread promotion modal on web
ClosedPublic
Actions

Authored by rohan on Dec 14 2022, 6:00 PM.
Tags
None
Referenced Files
F3382756: D5874.diff
Thu, Nov 28, 11:52 AM
Unknown Object (File)
Wed, Nov 13, 5:17 AM
Unknown Object (File)
Sat, Nov 9, 11:51 AM
Unknown Object (File)
Sat, Nov 9, 11:51 AM
Unknown Object (File)
Sat, Nov 9, 11:49 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Tue, Nov 5, 7:26 AM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
ashoat
Commits
rCOMM44f702fc8f8e: [web] Update thread promotion modal on web
Summary

This diff updates the thread promotion modal on web, following the Design task.

  1. Updated modal_body padding to 24px 32px 32px 32px
  2. Make the button the usual purple color
  3. Remove the line break between the text

Design Task: https://linear.app/comm/issue/DES-14/thread-promote-button-modal-looks-scary
Engineering Task: https://linear.app/comm/issue/ENG-2410/update-thread-promotion-modal-on-web

Test Plan

See screenshots below

Before:

Screenshot 2022-12-14 at 6.12.06 PM.png (720×1 px, 79 KB)

After:

Screenshot 2022-12-14 at 8.51.00 PM.png (638×1 px, 67 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ENG-2410
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
chat/
2 lines
15 lines

Diff 19362

View Options

web/modals/chat/sidebar-promote-modal.css

Loading...
View Options

web/modals/chat/sidebar-promote-modal.react.js

Loading...