Page MenuHomePhabricator
Differential D5879

[keyserver] remove opaque-ke-node
ClosedPublic
Actions

Authored by varun on Dec 15 2022, 4:08 PM.
Tags
None
Referenced Files
F3261953: D5879.id19971.diff
Fri, Nov 15, 11:31 PM
F3255736: D5879.diff
Fri, Nov 15, 8:29 PM
Unknown Object (File)
Fri, Nov 8, 10:01 AM
Unknown Object (File)
Fri, Nov 8, 10:01 AM
Unknown Object (File)
Wed, Nov 6, 7:09 PM
Unknown Object (File)
Tue, Nov 5, 7:26 AM
Unknown Object (File)
Mon, Nov 4, 9:43 AM
Unknown Object (File)
Mon, Nov 4, 9:43 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
Commits
rCOMM5b7551fb565d: [keyserver] remove opaque-ke-node
Summary

We're no longer using this addon so we can remove it from the repo

Test Plan

Built keyserver successfully, checked that no references to this package remained

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Dec 15 2022, 4:08 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2022, 4:08 PM
Harbormaster completed remote builds in B14196: Diff 19425.Dec 15 2022, 4:21 PM
varun requested review of this revision.Dec 15 2022, 4:21 PM
varun edited the test plan for this revision. (Show Details)Dec 15 2022, 4:47 PM
ashoat requested changes to this revision.Dec 16 2022, 7:08 AM

checked that no references to this package remained

Not sure what this means, but it appears you neglected to do a simple git grep opaque-ke-node as you forgot to remove the reference in the root package.json...

This revision now requires changes to proceed.Dec 16 2022, 7:08 AM
varun requested review of this revision.Dec 19 2022, 7:24 AM
varun removed a reviewer: atul.
In D5879#176258, @ashoat wrote:

checked that no references to this package remained

Not sure what this means, but it appears you neglected to do a simple git grep opaque-ke-node as you forgot to remove the reference in the root package.json...

I already removed that reference here...

ashoat accepted this revision.Dec 19 2022, 8:01 AM

My apologies, you're absolutely right. Not sure what I was thinking

This revision is now accepted and ready to land.Dec 19 2022, 8:01 AM
Closed by commit rCOMM5b7551fb565d: [keyserver] remove opaque-ke-node (authored by varun). · Explain WhyDec 21 2022, 11:36 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM5b7551fb565d: [keyserver] remove opaque-ke-node.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
opaque-ke-node/
src/

Diff 19425

View Options

keyserver/addons/opaque-ke-node/.gitignore

Loading...
View Options

keyserver/addons/opaque-ke-node/Cargo.lock

Loading...
View Options

keyserver/addons/opaque-ke-node/Cargo.toml

Loading...
View Options

keyserver/addons/opaque-ke-node/README.md

Loading...
View Options

keyserver/addons/opaque-ke-node/package.json

Loading...
View Options

keyserver/addons/opaque-ke-node/src/lib.rs

Loading...