[services/commtest] Adding of openssl, base64, anyhow to dependencies
ClosedPublic
Actions

Authored by • max on Dec 19 2022, 6:14 AM.

Details

Reviewers

Commits

Summary

This diff adds the following Rust crate dependencies to the commtest API testing app:

OpenSSL: We need it to make a signature for the string by the private key (in D5927), and generate keys as well (D5931).
Base64: We are representing the signed string in a base64 to send it to the Tunnelbroker (in D5927).
Anyhow: To be flexible in error types returns in utility functions we should use an Anyhow error type (in D5929).

Test Plan

The commtest app is successfully built and the tests are successfully passed in the following D5931.

Repository

rCOMM Comm

Branch

commtest-add-openssl-base64-deps

Lint

No Lint Coverage

Unit

No Test Coverage

• max held this revision as a draft.

• max published this revision for review.Dec 19 2022, 7:00 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: varun. • max added 1 blocking reviewer(s): • jon.

This revision is now accepted and ready to land.Dec 20 2022, 9:52 AM

This revision now requires review to proceed.Dec 22 2022, 6:59 AM

Adding @ashoat for a final pass.

This revision is now accepted and ready to land.Dec 22 2022, 8:01 AM

services/commtest/Cargo.toml
13	Should this be "vendored" like D5998? Don't really understand the concept, just asking

services/commtest/Cargo.toml
13	i think the "vendored" feature is only relevant for cross-compilation

services/commtest/Cargo.toml
13	er, actually, after reading the summary of D5998 there might be a different reason i'm not aware of

• max marked 3 inline comments as done.Dec 23 2022, 10:14 AM

• max added inline comments.

services/commtest/Cargo.toml
13	Should this be "vendored" like D5998? Don't really understand the concept, just asking If the vendored Cargo feature is enabled, the openssl crate will be used to compile and statically link to a copy of OpenSSL. It fails to build native apps without it. i think the "vendored" feature is only relevant for cross-compilation Yes, it's related to the cross-compilation as well. The native lib doesn't build without it.