[native] Separate redux-devtools out
ClosedPublic
Actions

Authored by ashoat on Dec 21 2022, 11:29 AM.

Details

Reviewers

bartek
• jon

Commits

rCOMM8a14ca93301b: [native] Separate redux-devtools out

Summary

After this diff, redux-devtools runs similar to react-devtools: as a separate standalone yarn command.

Other changes:

Updated our version of @redux-devtools/cli
Silenced console errors when redux-devtools isn't open
Added the --open flag so the user doesn't have to separately open the redux-devtools app on their own
Updated docs

Test Plan

Ran Redux dev tools in a variety of scenarios, including having a separate physical device connect to it
Ran the app without Redux dev tools to make sure it doesn't crash or spew too many errors

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/physicaldevice

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 21 2022, 11:29 AM

Herald added a reviewer: • jon. · View Herald TranscriptDec 21 2022, 11:29 AM

Herald added subscribers: atul, tomek. · View Herald Transcript

ashoat removed 1 blocking reviewer(s): • jon.Dec 21 2022, 11:31 AM

This comment was removed by ashoat.

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 21 2022, 11:32 AM

Harbormaster failed remote builds in B14641: Diff 19969!

Not a fan of @jon's Herald rule auto-added him as blocking... I think we should stick to adding as a reviewer, but not a blocking reviewer... prefer to rely on diff author for selecting their blocking reviewers

Dedup redux packages

Fixed a strange issue where two copies of redux-persist with the same version were being installed by Yarn: one in node_modules and the other in native/node_modules
patch-package was only capturing the root one, which meant that I was getting Flow errors from the copy of redux-persist in native/node_modules
The reason it was has happening was this rule: "we must not hoist a package higher than its peer dependencies"
This diff introduced something that caused redux versions to get separated between node_modules and native/node_modules, and the "must not hoist" rule meant that redux-persist had to be copied into native/node_modules
Got the tip from this GitHub comment