Page MenuHomePhabricator
Differential D6059

[keyserver] Decouple `processSuccessfulLogin` from `logInResponder`
ClosedPublic
Actions

Authored by atul on Dec 27 2022, 10:50 PM.
Tags
None
Referenced Files
F3539323: D6059.diff
Thu, Dec 26, 12:43 AM
Unknown Object (File)
Wed, Dec 18, 5:34 PM
Unknown Object (File)
Wed, Dec 18, 5:34 PM
Unknown Object (File)
Wed, Dec 18, 5:34 PM
Unknown Object (File)
Wed, Dec 18, 10:58 AM
Unknown Object (File)
Nov 25 2024, 11:47 AM
Unknown Object (File)
Nov 25 2024, 11:47 AM
Unknown Object (File)
Nov 18 2024, 1:44 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMb9f4b7436f5c: [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`
Summary

Pull out processSuccessfulLogin from logInResponder so the logic can be reused by siweAuthResponder.

These queries are run once password/signature are validated and the user has correctly authenticated.

Test Plan
  1. Create account with password
  2. Log in to ensure things work
  3. Log out
  4. Patch this diff in
  5. Successfully able to log in again

Not a super comprehensive test plan, but it should be a pretty straightforward refactor.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 27 2022, 10:50 PM
atul published this revision for review.Dec 27 2022, 10:50 PM
atul edited the summary of this revision. (Show Details)Dec 27 2022, 10:53 PM
Harbormaster completed remote builds in B14811: Diff 20202.Dec 27 2022, 11:04 PM
atul added a child revision: D6060: [keyserver] Introduce `fetchUserIDForEthereumAddress` and use in `siweAuthResponder`.Dec 27 2022, 11:19 PM
ashoat accepted this revision.Dec 28 2022, 6:07 AM

Not really reviewing too closely, assuming it's just a refactor

This revision is now accepted and ready to land.Dec 28 2022, 6:07 AM
ashoat added inline comments.Dec 28 2022, 6:21 AM
keyserver/src/responders/user-responders.js
193

I might call this something other than "queries" since it also encompasses setting user cookie etc.

Maybe processSuccessfulLogin?

atul added inline comments.Dec 28 2022, 2:27 PM
keyserver/src/responders/user-responders.js
193

Yeah, that's a clearer name.. will update this diff

atul updated this revision to Diff 20261.Dec 28 2022, 2:30 PM

address feedback (rename function)

atul retitled this revision from [keyserver] Decouple `successfulLogInQueries` from `logInResponder` to [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`.Dec 28 2022, 2:37 PM
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B14856: Diff 20261.Dec 28 2022, 2:44 PM
Closed by commit rCOMMb9f4b7436f5c: [keyserver] Decouple `processSuccessfulLogin` from `logInResponder` (authored by atul). · Explain WhyDec 28 2022, 2:47 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb9f4b7436f5c: [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
114 lines

Diff 20202

View Options

keyserver/src/responders/user-responders.js

Loading...