Page MenuHomePhabricator

[keyserver] Pass `calendarQuery` to `processSuccessfulLogin` in `siweAuthResponder`
ClosedPublic

Authored by atul on Dec 28 2022, 7:20 PM.
Tags
None
Referenced Files
F2211100: D6078.diff
Mon, Jul 8, 1:06 AM
Unknown Object (File)
Sun, Jul 7, 12:12 AM
Unknown Object (File)
Sat, Jul 6, 2:51 AM
Unknown Object (File)
Fri, Jul 5, 11:34 PM
Unknown Object (File)
Thu, Jul 4, 5:06 PM
Unknown Object (File)
Thu, Jul 4, 7:14 AM
Unknown Object (File)
Wed, Jul 3, 12:51 AM
Unknown Object (File)
Mon, Jul 1, 9:11 PM
Subscribers
None

Details

Summary

Context: https://linear.app/comm/issue/ENG-2575/pass-calendarquery-up-from-client-to-siweauthresponder

https://phab.comm.dev/D6060#inline-40815

Should have done this earlier... calendarQuery was already being included in SIWEAuthRequest.


Depends on D6077

Test Plan

Set breakpoints and observed that calendarQuery "made it" to processSuccessfulLogin as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Dec 28 2022, 7:21 PM
ashoat requested changes to this revision.Dec 28 2022, 7:25 PM

How about the native side to send this field up?

keyserver/src/responders/user-responders.js
337 ↗(On Diff #20276)

It shouldn't be optional. It's only optional for other responders to support old clients

This revision now requires changes to proceed.Dec 28 2022, 7:25 PM
keyserver/src/responders/user-responders.js
337 ↗(On Diff #20276)

Ah gotcha, updating

How about the native side to send this field up?

calendarQuery is already a required field of SIWEAuthServerCall.

don't include normalizeCalendarQuery as a step

This revision is now accepted and ready to land.Dec 28 2022, 8:27 PM

rebase around D6077 before landing