Page MenuHomePhabricator
Differential D6096

Soften requirement for password in account deletion request
ClosedPublic
Actions

Authored by marcin on Dec 29 2022, 4:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:36 PM
Unknown Object (File)
Oct 15 2024, 5:13 PM
Unknown Object (File)
Oct 6 2024, 3:50 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM5d99214912bc: Soften requirement for password in account deletion request
Summary

This differential softens requirement as to whether user should provide a password in account deletion request

Test Plan

Launch the app.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2541
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Dec 29 2022, 4:34 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 4:34 AM
marcin added a parent revision: D6095: Implement function to check whether account has password - currently checking for ethereum validity.Dec 29 2022, 4:34 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 29 2022, 4:38 AM
Harbormaster failed remote builds in B14910: Diff 20327!
marcin added a child revision: D6098: Implement logic to skip password validation when account does not have one.Dec 29 2022, 4:46 AM
marcin requested review of this revision.Dec 29 2022, 5:59 AM
marcin updated this revision to Diff 20337.Dec 29 2022, 6:15 AM

Bring back correct deleteAccountRequestInputValidator

Harbormaster failed remote builds in B14920: Diff 20337!Dec 29 2022, 6:19 AM
tomek accepted this revision.Dec 29 2022, 6:28 AM
This revision is now accepted and ready to land.Dec 29 2022, 6:28 AM
marcin updated this revision to Diff 20351.Dec 29 2022, 8:46 AM

Rebase master

Harbormaster completed remote builds in B14933: Diff 20351.Dec 29 2022, 9:01 AM
marcin updated this revision to Diff 20416.Dec 30 2022, 3:35 AM

Rebase before landing

Harbormaster completed remote builds in B14965: Diff 20416.Dec 30 2022, 3:48 AM
Closed by commit rCOMM5d99214912bc: Soften requirement for password in account deletion request (authored by marcin). · Explain WhyDec 30 2022, 4:13 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM5d99214912bc: Soften requirement for password in account deletion request.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines
lib/
actions/
2 lines
types/
2 lines

Diff 20327

View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/account-types.js

Loading...