Implement function to check whether account has password - currently checking for ethereum validity
ClosedPublic
Actions

Authored by marcin on Dec 29 2022, 4:31 AM.

Details

Reviewers

tomek
atul

Commits

rCOMMc3bfb9bf682d: Implement function to check whether account has password - currently checking…

Summary

This differential implements utility function to check whether an account has password. Currently this operation is logically equivalent to check whether currentUserInfo is null or logged out or represents ethereum account (returns false). returns true otherwise.

Test Plan

Create SIWE account and log return result of this function. Should be false. Then in normal account log the result of this function. Should be true.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Dec 29 2022, 4:31 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 4:31 AM

marcin added a child revision: D6096: Soften requirement for password in account deletion request.Dec 29 2022, 4:34 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 29 2022, 4:35 AM

Harbormaster failed remote builds in B14909: Diff 20326!

marcin requested review of this revision.Dec 29 2022, 5:57 AM

tomek accepted this revision.Dec 29 2022, 6:23 AM

tomek added inline comments.

lib/shared/account-utils.js
80 ↗	(On Diff #20326)	Is it possible to create an account with password that has a username that looks like an address?

This revision is now accepted and ready to land.Dec 29 2022, 6:23 AM

marcin added inline comments.Dec 29 2022, 6:57 AM

lib/shared/account-utils.js
80 ↗	(On Diff #20326)	I can't say for sure, but implementation of this function strictly reflects this requirement: https://linear.app/comm/issue/ENG-2541#comment-5b40623e.