[native] Handle errors with SIWE WebView
ClosedPublic
Actions

Authored by michal on Dec 29 2022, 4:41 AM.

Details

Reviewers

atul
tomek
kamil

Commits

rCOMM83d66a15706e: [native] Handle errors with SIWE WebView

Summary

More context in this comment: ENG-2544.
The current error message isn't great, so this diff replaces it with an alert.

Test Plan

For testing I forced getSIWENonceCallFailed to be always true and checked if the alert is displayed and if it returns to the login screen when you press "OK".

Diff Detail

Repository

rCOMM Comm

Branch

michal/siwe-work

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Dec 29 2022, 4:41 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 4:41 AM

michal edited the summary of this revision. (Show Details)Dec 29 2022, 4:42 AM

Harbormaster completed remote builds in B14912: Diff 20329.Dec 29 2022, 4:54 AM

michal requested review of this revision.Dec 29 2022, 4:54 AM

tomek accepted this revision.Dec 29 2022, 6:56 AM

tomek added inline comments.

native/account/siwe-panel.react.js
227–236	Can we place this near something related, e.g. just below `getSIWENonceCallFailed` selector?

This revision is now accepted and ready to land.Dec 29 2022, 6:56 AM

Moved code a bit.

Harbormaster completed remote builds in B14959: Diff 20408.Dec 30 2022, 2:28 AM

Closed by commit rCOMM83d66a15706e: [native] Handle errors with SIWE WebView (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyDec 30 2022, 2:31 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM83d66a15706e: [native] Handle errors with SIWE WebView.

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

17 lines

Diff 20329

View Options

native/account/siwe-panel.react.js

[native] Handle errors with SIWE WebViewClosedPublicActions