Page MenuHomePhabricator

Implement logic to skip password validation when account does not have one
ClosedPublic

Authored by marcin on Dec 29 2022, 4:45 AM.
Tags
None
Referenced Files
F3492789: D6098.id20332.diff
Thu, Dec 19, 1:36 AM
F3492584: D6098.id20352.diff
Thu, Dec 19, 12:42 AM
F3492234: D6098.diff
Wed, Dec 18, 10:42 PM
Unknown Object (File)
Mon, Dec 16, 12:49 AM
Unknown Object (File)
Sat, Nov 30, 4:03 PM
Unknown Object (File)
Thu, Nov 28, 11:15 AM
Unknown Object (File)
Thu, Nov 28, 11:15 AM
Unknown Object (File)
Sun, Nov 24, 2:42 PM
Subscribers

Details

Summary

This differential implements new log to handle account deletion request. Firstly consistency of request and DB is checked against. If account deletion request does not have password then DB should have NULL value in hasn column and vice versa. Then if request is consistent with the DB,
request password validity is checked against only if hash column is not NULL. If request is not consistent with DB or DB hash does not match request password, error is thrown.

Test Plan

Create SIWE account, go to delete account panel, type any string in password input prompt and succesfully deletre account.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2541
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 29 2022, 4:50 AM
Harbormaster failed remote builds in B14915: Diff 20332!
This revision is now accepted and ready to land.Dec 29 2022, 6:33 AM