Page MenuHomePhabricator
Differential D6102

Ignore password when deleting thread on the server side
ClosedPublic
Actions

Authored by marcin on Dec 29 2022, 6:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:38 PM
Unknown Object (File)
Sat, Nov 30, 6:55 AM
Unknown Object (File)
Thu, Nov 28, 11:16 AM
Unknown Object (File)
Nov 8 2024, 8:15 AM
Unknown Object (File)
Nov 8 2024, 8:15 AM
Unknown Object (File)
Nov 5 2024, 1:42 AM
Unknown Object (File)
Nov 5 2024, 1:41 AM
Unknown Object (File)
Oct 27 2024, 9:21 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM43290dbd766e: Ignore password when deleting thread on the server side
Summary

This differential makes keyserver ignore password coming in thread deletion request.

Test Plan

Create SIWE account, give it relevant privilages (for example hardcode canDeleteThread to be always true). Enter chat settings and delete chat providing any password. Ensure thread is deleted

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Dec 29 2022, 6:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 6:51 AM
marcin published this revision for review.Dec 29 2022, 6:52 AM
marcin added a parent revision: D6101: Soften requirements for password when deleting thread.
marcin added a child revision: D6103: Do not prompt for password when deleting thread.Dec 29 2022, 6:55 AM
Harbormaster failed remote builds in B14922: Diff 20339!Dec 29 2022, 6:55 AM
tomek accepted this revision.Dec 29 2022, 7:05 AM
This revision is now accepted and ready to land.Dec 29 2022, 7:05 AM
ashoat added a comment.EditedDec 29 2022, 8:22 AM

We need the equivalent changes on web as well. See point 2 in this comment

marcin updated this revision to Diff 20355.Dec 29 2022, 8:48 AM

Rebase master

Harbormaster completed remote builds in B14937: Diff 20355.Dec 29 2022, 9:02 AM
marcin updated this revision to Diff 20420.Dec 30 2022, 3:37 AM

Rebase before landing

marcin added a comment.Dec 30 2022, 3:41 AM
In D6102#182989, @ashoat wrote:

We need the equivalent changes on web as well. See point 2 in this comment

Done by D6105

Harbormaster completed remote builds in B14969: Diff 20420.Dec 30 2022, 3:50 AM
Closed by commit rCOMM43290dbd766e: Ignore password when deleting thread on the server side (authored by marcin). · Explain WhyDec 30 2022, 4:13 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM43290dbd766e: Ignore password when deleting thread on the server side.

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
11 lines

Diff 20355

View Options

keyserver/src/deleters/thread-deleters.js

Loading...