Differential D6111

[landing] Revert RainbowKit patch in D6018
ClosedPublic
Actions

Authored by ashoat on Dec 29 2022, 6:41 PM.

Details

Reviewers

atul

Commits

rCOMM8c016d1beb79: [landing] Revert RainbowKit patch in D6018

Summary

This caused ENG-2578. Oops!!

The original patch just fixed behavior when no wallet was installed... otherwise the deeplink to the Play Store failed. But that's not so bad of an issue... the user can figure out a way to install the app given they selected it.

Test Plan

Test end-to-end flow on a physical Android device

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/siwe

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 29 2022, 6:41 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 29 2022, 6:41 PM

ashoat added a child revision: D6112: [landing] Add localStorage.clear() call to landing/script.js.Dec 29 2022, 6:46 PM

Harbormaster completed remote builds in B14956: Diff 20403.Dec 29 2022, 6:55 PM

ashoat requested review of this revision.Dec 29 2022, 6:55 PM

atul accepted this revision.Dec 30 2022, 11:36 AM

This revision is now accepted and ready to land.Dec 30 2022, 11:36 AM

Closed by commit rCOMM8c016d1beb79: [landing] Revert RainbowKit patch in D6018 (authored by ashoat). · Explain WhyDec 30 2022, 5:19 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8c016d1beb79: [landing] Revert RainbowKit patch in D6018.

Revision Contents
Changeset List

Path

Size

patches/

@rainbow-me+rainbowkit+0.5.3.patch

29 lines

Diff 20403

View Options

patches/@rainbow-me+rainbowkit+0.5.3.patch

[landing] Revert RainbowKit patch in D6018ClosedPublicActions