Page MenuHomePhabricator

[native] Handle errors with SIWE WebView
ClosedPublic

Authored by michal on Dec 29 2022, 4:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 11:26 PM
Unknown Object (File)
Mon, Nov 4, 11:26 PM
Unknown Object (File)
Mon, Nov 4, 6:53 AM
Unknown Object (File)
Tue, Oct 22, 5:17 PM
Unknown Object (File)
Tue, Oct 22, 5:17 PM
Unknown Object (File)
Tue, Oct 22, 5:17 PM
Unknown Object (File)
Tue, Oct 22, 2:27 AM
Unknown Object (File)
Tue, Oct 22, 12:27 AM
Subscribers

Details

Summary

More context in this comment: ENG-2544.
The current error message isn't great, so this diff replaces it with an alert.

image.png (1×692 px, 132 KB)

Test Plan

For testing I forced getSIWENonceCallFailed to be always true and checked if the alert is displayed and if it returns to the login screen when you press "OK".

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
native/account/siwe-panel.react.js
227–236 ↗(On Diff #20329)

Can we place this near something related, e.g. just below getSIWENonceCallFailed selector?

This revision is now accepted and ready to land.Dec 29 2022, 6:56 AM