Page MenuHomePhabricator

Ignore password when deleting thread on the server side
ClosedPublic

Authored by marcin on Dec 29 2022, 6:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 8:49 PM
Unknown Object (File)
Fri, Dec 20, 8:31 PM
Unknown Object (File)
Thu, Dec 19, 4:31 AM
Unknown Object (File)
Thu, Dec 19, 1:52 AM
Unknown Object (File)
Fri, Dec 13, 1:38 PM
Unknown Object (File)
Sat, Nov 30, 6:55 AM
Unknown Object (File)
Thu, Nov 28, 11:16 AM
Unknown Object (File)
Nov 8 2024, 8:15 AM
Subscribers

Details

Summary

This differential makes keyserver ignore password coming in thread deletion request.

Test Plan

Create SIWE account, give it relevant privilages (for example hardcode canDeleteThread to be always true). Enter chat settings and delete chat providing any password. Ensure thread is deleted

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 29 2022, 7:05 AM

We need the equivalent changes on web as well. See point 2 in this comment

We need the equivalent changes on web as well. See point 2 in this comment

Done by D6105