Page MenuHomePhabricator
Differential D6140

Remove all react-native-notifications usages on iOS
ClosedPublic
Actions

Authored by marcin on Jan 2 2023, 6:49 AM.
Tags
None
Referenced Files
F3499484: D6140.id20504.diff
Thu, Dec 19, 11:22 PM
F3499150: D6140.id21424.diff
Thu, Dec 19, 10:39 PM
F3497002: D6140.diff
Thu, Dec 19, 5:15 PM
Unknown Object (File)
Tue, Dec 17, 6:24 AM
Unknown Object (File)
Tue, Dec 17, 6:24 AM
Unknown Object (File)
Tue, Dec 17, 6:24 AM
Unknown Object (File)
Tue, Dec 17, 6:24 AM
Unknown Object (File)
Tue, Dec 17, 6:23 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMMc3a74431925b: Remove all react-native-notifications usages on iOS
Summary

This differential replaces all remaining usages of NotificationsIOS with CommIOSNotifications.

Test Plan

Ensure that updating badge count, removing and getting all delivered notifications work in JavaScript.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2334
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 2 2023, 6:49 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 2 2023, 6:49 AM
marcin added a parent revision: D6139: Export Background Fetch result constants from CommIOSNotifications to JavaScript.Jan 2 2023, 6:50 AM
Harbormaster completed remote builds in B15026: Diff 20504.Jan 2 2023, 7:03 AM
marcin requested review of this revision.Jan 2 2023, 7:03 AM
marcin added a child revision: D6141: Remove react-native-notifications dependency from project.Jan 2 2023, 7:34 AM
tomek accepted this revision.Jan 5 2023, 8:40 AM
This revision is now accepted and ready to land.Jan 5 2023, 8:40 AM
marcin updated this revision to Diff 21016.Jan 17 2023, 7:27 AM
  1. Tiny change in a way we remove all notifications for a given thread. Now we can directly access threadID as a property.
Harbormaster completed remote builds in B15414: Diff 21016.Jan 17 2023, 7:41 AM
marcin updated this revision to Diff 21044.Jan 18 2023, 7:03 AM

Refactor

Harbormaster failed remote builds in B15435: Diff 21044!Jan 18 2023, 7:06 AM
marcin updated this revision to Diff 21424.Jan 27 2023, 1:08 AM

Rebase before landing

Harbormaster completed remote builds in B15715: Diff 21424.Jan 27 2023, 1:22 AM
Closed by commit rCOMMc3a74431925b: Remove all react-native-notifications usages on iOS (authored by marcin). · Explain WhyJan 27 2023, 1:52 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMc3a74431925b: Remove all react-native-notifications usages on iOS.

Revision Contents
Changeset List

PathSize
native/
push/
33 lines

Diff 20504

View Options

native/push/push-handler.react.js

Loading...