Page MenuHomePhabricator
Differential D6148

[lib] Simplify InlineSidebarText and deprecate sendersText
ClosedPublic
Actions

Authored by ashoat on Jan 3 2023, 9:10 AM.
Tags
None
Referenced Files
F3564057: D6148.diff
Fri, Dec 27, 1:20 PM
Unknown Object (File)
Fri, Dec 6, 8:19 AM
Unknown Object (File)
Sat, Nov 30, 10:07 AM
Unknown Object (File)
Sat, Nov 30, 10:07 AM
Unknown Object (File)
Sat, Nov 30, 12:51 AM
Unknown Object (File)
Nov 22 2024, 4:44 AM
Unknown Object (File)
Nov 22 2024, 4:44 AM
Unknown Object (File)
Nov 22 2024, 4:44 AM
View All Files
Subscribers
atul
tomek

Details

Reviewers
ginsu
Commits
rCOMM7c75cd42f2f3: [lib] Simplify InlineSidebarText and deprecate sendersText
Summary

We're not using sendersText anymore, so we should get rid of that code.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/inline-sidebar-text
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jan 3 2023, 9:10 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptJan 3 2023, 9:10 AM
ashoat added inline comments.Jan 3 2023, 9:11 AM
lib/hooks/inline-sidebar-text.react.js
29

No need for memo anymore now that we're returning a primitive (which handle deep equality checks)

Harbormaster completed remote builds in B15043: Diff 20523.Jan 3 2023, 9:24 AM
ashoat requested review of this revision.Jan 3 2023, 9:24 AM
ginsu accepted this revision.Jan 4 2023, 7:26 AM
This revision is now accepted and ready to land.Jan 4 2023, 7:26 AM
Closed by commit rCOMM7c75cd42f2f3: [lib] Simplify InlineSidebarText and deprecate sendersText (authored by ashoat). · Explain WhyJan 4 2023, 6:17 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7c75cd42f2f3: [lib] Simplify InlineSidebarText and deprecate sendersText.

Revision Contents
Changeset List

PathSize
lib/
hooks/
44 lines
native/
chat/
2 lines
web/
chat/
8 lines

Diff 20523

View Options

lib/hooks/inline-sidebar-text.react.js

Loading...
View Options

native/chat/inline-sidebar.react.js

Loading...
View Options

web/chat/inline-sidebar.react.js

Loading...