Page MenuHomePhabricator
Differential D6174

[desktop] Enable flow in the desktop workspace
ClosedPublic
Actions

Authored by michal on Jan 5 2023, 4:33 AM.
Tags
None
Referenced Files
F3512085: D6174.diff
Sat, Dec 21, 6:03 PM
Unknown Object (File)
Mon, Dec 2, 3:33 PM
Unknown Object (File)
Sat, Nov 30, 12:54 AM
Unknown Object (File)
Sat, Nov 30, 12:54 AM
Unknown Object (File)
Sat, Nov 30, 12:53 AM
Unknown Object (File)
Sat, Nov 30, 12:53 AM
Unknown Object (File)
Thu, Nov 28, 4:06 AM
Unknown Object (File)
Fri, Nov 22, 4:10 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMMe1af827cf64f: [desktop] Enable flow in the desktop workspace
Summary

ENG-2219
Adds flow support in the desktop workspace.

Test Plan
  • Run flow in desktop
  • Check if lint-staged fails when trying to commit file with type errors

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Jan 5 2023, 4:33 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 5 2023, 4:34 AM
michal updated this revision to Diff 20612.Jan 5 2023, 4:36 AM

Remove lib from dependencies (it was supposed to be in a next diff)

Harbormaster completed remote builds in B15116: Diff 20611.Jan 5 2023, 4:48 AM
Harbormaster completed remote builds in B15117: Diff 20612.Jan 5 2023, 4:50 AM
michal requested review of this revision.Jan 5 2023, 4:50 AM
michal added a child revision: D6175: [desktop] Type bridge object between desktop and web.Jan 5 2023, 4:53 AM
ashoat requested changes to this revision.Jan 5 2023, 8:28 AM

We should add this Flow check to CI: .buildkite/eslint_flow_jest.yml and .github/workflows/eslint_flow_jest.yml

desktop/package.json
37

We should also add flow-typed

desktop/src/main.js
1

Please add a newline below here

desktop/src/preload.js
1

Please add a newline below here

This revision now requires changes to proceed.Jan 5 2023, 8:28 AM
michal updated this revision to Diff 20654.Jan 9 2023, 2:23 AM

Add flow-typed dep, add newlines, add to GitHub and Buildkite CI.

Harbormaster completed remote builds in B15146: Diff 20654.Jan 9 2023, 2:38 AM
ashoat accepted this revision.Jan 9 2023, 8:24 AM
This revision is now accepted and ready to land.Jan 9 2023, 8:24 AM
Closed by commit rCOMMe1af827cf64f: [desktop] Enable flow in the desktop workspace (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 11 2023, 7:10 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMe1af827cf64f: [desktop] Enable flow in the desktop workspace.

Revision Contents
Changeset List

PathSize
3 lines
desktop/
3 lines
29 lines
1 line
flow-typed/
npm/
19 lines
8 lines
1 line
src/
3 lines
1 line
1 line
native/
1 line

Diff 20612

View Options

.lintstagedrc.js

Loading...
View Options

desktop/.eslintrc.json

Loading...
View Options

desktop/.flowconfig

Loading...
View Options

desktop/babel.config.cjs

Loading...
View Options

desktop/flow-typed/npm/electron_vx.x.x.js

Loading...
View Options

desktop/forge.config.cjs

Loading...
View Options

desktop/package.json

Loading...
View Options

desktop/src/handle-squirrel-event.js

Loading...
View Options

desktop/src/main.js

Loading...
View Options

desktop/src/preload.js

Loading...
View Options

native/.flowconfig

Loading...