Page MenuHomePhabricator
Differential D6193

[native] Fix FlatList scroll perf issues on Android 13
ClosedPublic
Actions

Authored by ashoat on Jan 6 2023, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:58 AM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:13 AM
Unknown Object (File)
Tue, Oct 15, 2:04 PM
Unknown Object (File)
Oct 14 2024, 10:03 PM
View All Files
Subscribers
None

Details

Reviewers
tomek
bartek
atul
Commits
rCOMM1fefaeea8bc1: [native] Fix FlatList scroll perf issues on Android 13
Summary

See context on this Linear issue and this React Native GitHub issue. The original fix comes from here, but in React Native 0.70 that style prop gets deprecated, so this additional hack is necessary.

Test Plan

Compiled Android release build on physical Android 13 device

beforeaction

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 6 2023, 6:06 PM
Harbormaster completed remote builds in B15141: Diff 20647.Jan 6 2023, 6:20 PM
ashoat requested review of this revision.Jan 6 2023, 6:20 PM
ashoat edited the test plan for this revision. (Show Details)Jan 6 2023, 6:29 PM
bartek added inline comments.Jan 6 2023, 11:12 PM
patches/react-native+0.70.6.patch
32–38 ↗(On Diff #20647)

Is verticallyInverted now defined twice?

ashoat added inline comments.Jan 7 2023, 10:03 AM
patches/react-native+0.70.6.patch
32–38 ↗(On Diff #20647)

Ah yeah, sorry. I'll remove the first instance

ashoat updated this revision to Diff 20648.Jan 7 2023, 10:17 AM

Delete the old version of the style

Harbormaster completed remote builds in B15142: Diff 20648.Jan 7 2023, 10:32 AM
bartek accepted this revision.Jan 9 2023, 12:10 AM

In the future, if the deprecated style prop was removed, we might consider switching to @shopify/flash-list. Created ENG-2667 to discuss it.

This revision is now accepted and ready to land.Jan 9 2023, 12:10 AM
tomek accepted this revision.Jan 9 2023, 2:28 AM
Closed by commit rCOMM1fefaeea8bc1: [native] Fix FlatList scroll perf issues on Android 13 (authored by ashoat). · Explain WhyJan 9 2023, 7:30 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1fefaeea8bc1: [native] Fix FlatList scroll perf issues on Android 13.

Revision Contents
Changeset List

PathSize
native/
10 lines
patches/
26 lines

Diff 20708

View Options

native/index.js

Loading...
View Options

patches/react-native+0.70.6.patch

Loading...