Paths

Table of Contentst

[CI] Install protoc before calling yarn
ClosedPublic
Actions

Authored by • jon on Jan 12 2023, 10:29 AM.

Details

Reviewers

atul
varun
ashoat

Commits

rCOMM334db77d43cc: Revert "[web] Conditionally display `ConnectButton` once `nonce` received from…
rCOMM07274e254b9f: [CI] Install protoc before calling yarn

Summary

'yarn cleaninstall' now requires protoc to be available for the
rust-node-addon package to successfully build.

Move install_protobuf.sh to a shared location as non-android workflows may
need to use the script

Test Plan

https://buildkite.com/comm/android-build/builds/9597#0185a732-17b0-4b0f-aad2-40d30bba8c06 passes

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/fix-android-ci-protoc

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jan 12 2023, 10:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 12 2023, 10:29 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2023, 10:42 AM

Harbormaster failed remote builds in B15316: Diff 20891!

Harbormaster completed remote builds in B15316: Diff 20891.Jan 12 2023, 11:25 AM

• jon requested review of this revision.Jan 12 2023, 11:25 AM

varun accepted this revision.Jan 12 2023, 12:17 PM

This revision is now accepted and ready to land.Jan 12 2023, 12:17 PM

👍🏽

Closed by commit rCOMM07274e254b9f: [CI] Install protoc before calling yarn (authored by • jon). · Explain WhyJan 12 2023, 1:58 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM07274e254b9f: [CI] Install protoc before calling yarn.

atul added a commit: rCOMM334db77d43cc: Revert "[web] Conditionally display `ConnectButton` once `nonce` received from….Jan 12 2023, 3:43 PM

Revision Contents
Changeset List

Path

Size

.buildkite/

android.yml

2 lines

.github/

workflows/

android_ci.yml

2 lines

android_release.yml

2 lines

native/

android/

scripts/

install_protobuf.sh

			scripts/
	native/	android/	scripts/

install_protobuf.sh

24 lines

Diff 20891

View Options

.buildkite/android.yml

View Options

.github/workflows/android_ci.yml

View Options

.github/workflows/android_release.yml

View Options

native/android/scripts/install_protobuf.sh

View Options

scripts/install_protobuf.sh

[CI] Install protoc before calling yarnClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20891

.buildkite/android.yml

.github/workflows/android_ci.yml

.github/workflows/android_release.yml

native/android/scripts/install_protobuf.sh

scripts/install_protobuf.sh

[CI] Install protoc before calling yarn
ClosedPublic
Actions

Revision Contents
Changeset List