Page MenuHomePhabricator
Differential D6307

[lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action
ClosedPublic
Actions

Authored by ginsu on Jan 18 2023, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 10:04 AM
Unknown Object (File)
Wed, Jun 12, 3:18 AM
Unknown Object (File)
May 8 2024, 6:59 PM
Unknown Object (File)
May 5 2024, 5:43 PM
Unknown Object (File)
May 4 2024, 2:08 AM
Unknown Object (File)
May 2 2024, 5:44 AM
Unknown Object (File)
May 1 2024, 11:48 AM
Unknown Object (File)
Apr 29 2024, 12:32 AM
View All 34 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType…
Summary

Modified generatesNotifs in reaction-message-spec to return notif if the reaction action is equal to add_reaction and rescind if the reaction action is equal to remove_reaction

Won't land this diff until the entire stack for this task is accepted and ready to land. The current changes would cause notifs to no longer send if a user were to unlike a message

Linear Task: ENG-2644

Test Plan

This will be further tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Branch
eng-2644 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 18 2023, 7:35 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 18 2023, 7:35 PM
ginsu edited the summary of this revision. (Show Details)Jan 18 2023, 7:38 PM
ginsu added reviewers: atul, tomek.
Harbormaster completed remote builds in B15448: Diff 21060.Jan 18 2023, 7:49 PM
ginsu requested review of this revision.Jan 18 2023, 7:49 PM
tomek accepted this revision.Jan 19 2023, 3:40 AM
This revision is now accepted and ready to land.Jan 19 2023, 3:40 AM
ginsu added a child revision: D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.Feb 21 2023, 10:49 PM
ginsu updated this revision to Diff 23102.Feb 26 2023, 11:09 AM

rebase before landing

Harbormaster completed remote builds in B16911: Diff 23102.Feb 26 2023, 11:25 AM
Closed by commit rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType… (authored by ginsu). · Explain WhyFeb 26 2023, 1:06 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1f10bbfc7149: [lib] modify reaction message generatesNotifs function to return a pushType….

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
10 lines

Diff 21060

View Options

lib/shared/messages/reaction-message-spec.js

Loading...