Page MenuHomePhabricator

[lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action
ClosedPublic

Authored by ginsu on Jan 18 2023, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 27 2024, 2:02 AM
Unknown Object (File)
Feb 19 2024, 7:13 PM
Unknown Object (File)
Feb 19 2024, 6:49 PM
Unknown Object (File)
Feb 19 2024, 6:43 PM
Unknown Object (File)
Feb 19 2024, 3:01 PM
Unknown Object (File)
Feb 19 2024, 8:25 AM
Unknown Object (File)
Feb 10 2024, 4:56 PM
Unknown Object (File)
Jan 17 2024, 12:54 AM
Subscribers

Details

Summary

Modified generatesNotifs in reaction-message-spec to return notif if the reaction action is equal to add_reaction and rescind if the reaction action is equal to remove_reaction

Won't land this diff until the entire stack for this task is accepted and ready to land. The current changes would cause notifs to no longer send if a user were to unlike a message


Linear Task: ENG-2644

Test Plan

This will be further tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu added reviewers: atul, tomek.
ginsu requested review of this revision.Jan 18 2023, 7:49 PM
This revision is now accepted and ready to land.Jan 19 2023, 3:40 AM