Page MenuHomePhabricator

[Nix] Re-instate nixConfig
ClosedPublic

Authored by jon on Jan 17 2023, 7:22 AM.
Tags
None
Referenced Files
F3295890: D6286.id21012.diff
Sat, Nov 16, 11:41 PM
F3295464: D6286.diff
Sat, Nov 16, 9:44 PM
Unknown Object (File)
Thu, Nov 14, 4:43 PM
Unknown Object (File)
Fri, Nov 8, 10:09 AM
Unknown Object (File)
Fri, Nov 8, 10:09 AM
Unknown Object (File)
Fri, Nov 8, 10:09 AM
Unknown Object (File)
Tue, Oct 29, 9:52 PM
Unknown Object (File)
Tue, Oct 29, 9:52 PM
Subscribers

Details

Summary

Previously, the nixConfig did not work with just
the substitutor and public-keys defined. However, when looking
into how Cachix provisions a user environment, I noticed that
it defines the extra- variants as well. Having both the
non-prefixed and extra- prefix versions of the settings
seems to cover more corner cases.

Partial solution to https://linear.app/comm/issue/ENG-2623
May solve https://linear.app/comm/issue/ENG-2627

Test Plan

Since we're testing whether a package will be download, we have to
remove the previous versions of those commands in the nix store. However,
removal of gc roots may be quite involved, one would need to:

  • Exit all nix shells
  • Remove any symlinks to the nix store (e.g. result -> /nix/store/...)
  • Potential gc pinning from other tools (e.g. direnv)
# Remove gc roots
nix-collect-garbage
nix develop
# There shouldn't be any downloads

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable