Because we have both mobile and desktop releases in our github repo we need to add a small change to the Hazel electron update server so that it only looks for releases that have a git tag that looks like desktop-vX.Y.Z.
Depends on D6353
Details
Details
Check if hazel correctly looks for desktop-vX.Y.Z git tags and ignores other tags.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Move the patch to the root level.
NOTE: patch-package is run only in the postinstall script of the native workspace. So if native built before electron-update-server the hazel patch wouldn't be applied. So we probably have two options:
- add patch-package to root and call it in the postinstall
- add a postinstall script in the update server that's cd ../.. && yarn patch-package
Comment Actions
It's important that yarn patch-package runs before pod install, and the best way I've found to guarantee that is to include it in native/package.json. I don't think it's bad to call patch-package multiple times
NOTE: patch-package is run only in the postinstall script of the native workspace. So if native built before electron-update-server the hazel patch wouldn't be applied.
Can you clarify this scenario a bit more?
- add patch-package to root and call it in the postinstall
- add a postinstall script in the update server that's cd ../.. && yarn patch-package
I'm not sure, but I think either will work as long as we leave the patch-package call in native untouched.
Comment Actions
Can you clarify this scenario a bit more?
Something like this:
- yarn cleaninstall is run and everything is cleaned
- All native dependencies are installed
- postinstall in native is called (-> hazel is not patched because it doesn't exist in the node_modules yet)
- All electron-update-server dependencies are installed
In the end hazel is installed but isn't patched
I've made diff that adds patch-package to root in D6391
Comment Actions
Is this a hypothetical scenario, or were you able to observe it? I would've assumed that postinstall hooks won't run until all dependencies (for all workspaces) are installed
Comment Actions
Is this a hypothetical scenario, or were you able to observe it?
I wasn't able to observe it because native takes much longer than electron-update-server to install but I've tested it by making a small repo with this structure:
- workspace
- workspace member A, that has one dependency depA
- workspace member B, that has one dependency depB
(Neither depA not depB are members of the workspace).
I was able to get this order of postinstall scripts:
- depB
- B
- depA
- A
- workspace
So postinstall scripts run as soon as all dependencies were installed.