Page MenuHomePhabricator

[native] implement new InlineEngagement design
ClosedPublic

Authored by ginsu on Jan 23 2023, 10:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 12:26 AM
Unknown Object (File)
Fri, Nov 8, 2:58 AM
Unknown Object (File)
Fri, Nov 8, 2:58 AM
Unknown Object (File)
Fri, Nov 8, 2:58 AM
Unknown Object (File)
Fri, Nov 8, 2:58 AM
Unknown Object (File)
Fri, Nov 8, 2:58 AM
Unknown Object (File)
Fri, Nov 1, 6:01 PM
Unknown Object (File)
Wed, Oct 30, 6:37 PM
Subscribers

Details

Summary

implemented the new InlineEngagement design. The new design splits the InlineEngagement into two separate parts


Depends on D6350
Linear Task: ENG-2720

Test Plan

Please watch the demo video to see the new InlineEngagement

Diff Detail

Repository
rCOMM Comm
Branch
eng-2465 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek.

address ashoat's comments

atul added inline comments.
native/chat/inline-engagement.react.js
55

Do we really need to introduce a new noThreadInfo variable for this?

57

Can we just do !threadInfo here?

This revision is now accepted and ready to land.Jan 24 2023, 11:05 AM