Page MenuHomePhabricator
Differential D6427

[lib] Factor out constants in ENSCache tests
ClosedPublic
Actions

Authored by ashoat on Jan 28 2023, 7:01 AM.
Tags
None
Referenced Files
F2859017: D6427.id21508.diff
Tue, Oct 1, 12:14 PM
F2858292: D6427.diff
Tue, Oct 1, 10:23 AM
Unknown Object (File)
Mon, Sep 30, 7:16 AM
Unknown Object (File)
Thu, Sep 12, 1:51 AM
Unknown Object (File)
Thu, Sep 12, 1:51 AM
Unknown Object (File)
Thu, Sep 12, 1:51 AM
Unknown Object (File)
Thu, Sep 12, 1:48 AM
Unknown Object (File)
Tue, Sep 3, 7:13 PM
View All 44 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM161b29205667: [lib] Factor out constants in ENSCache tests
Summary

Depends on D6426

Test Plan

cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 28 2023, 7:01 AM
Herald added a subscriber: tomek. · View Herald TranscriptJan 28 2023, 7:01 AM
ashoat added a child revision: D6428: [lib] Modify ENSCache test so ETH address normalization is checked.Jan 28 2023, 7:05 AM
Harbormaster completed remote builds in B15763: Diff 21495.Jan 28 2023, 7:13 AM
ashoat requested review of this revision.Jan 28 2023, 7:13 AM
atul accepted this revision.Jan 28 2023, 12:47 PM
atul added inline comments.
lib/utils/ens-cache.test.js
36 ↗(On Diff #21495)

Super minor nit, but would personally prefer ashoatAddress or even ashoatETHAddress

But if this causes subsequent lines to extend past 80 characters and get formatted weird, shortened variable name might be better tradeoff?

This revision is now accepted and ready to land.Jan 28 2023, 12:47 PM
ashoat added inline comments.Jan 28 2023, 1:14 PM
lib/utils/ens-cache.test.js
36 ↗(On Diff #21495)

Yeah reducing line length for nice formatting was my priority

Closed by commit rCOMM161b29205667: [lib] Factor out constants in ENSCache tests (authored by ashoat). · Explain WhyJan 28 2023, 1:20 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM161b29205667: [lib] Factor out constants in ENSCache tests.

Revision Contents
Changeset List

PathSize
lib/
utils/
43 lines

Diff 21508

View Options

lib/utils/ens-cache.test.js

Loading...