[web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in `SIWE` component
ClosedPublic
Actions

Authored by atul on Jan 30 2023, 1:05 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM1dd0d74e03b3: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in…

Summary

Use Redux instead of React.State for primaryIdentityPublicKey. Mostly so we can persist via redux-persist.

Depends on D6434

Test Plan

Monitored Redux DevTools and observed that actions fired as expected and that actions modified state as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

cut newline

atul edited the summary of this revision. (Show Details)Jan 30 2023, 1:07 AM

atul added a parent revision: D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.

Harbormaster completed remote builds in B15798: Diff 21544.Jan 30 2023, 1:19 AM

Harbormaster completed remote builds in B15799: Diff 21545.

atul requested review of this revision.Jan 30 2023, 1:20 AM

tomek accepted this revision.Jan 30 2023, 12:30 PM

This revision is now accepted and ready to land.Jan 30 2023, 12:30 PM

ashoat accepted this revision.Jan 30 2023, 5:48 PM

rebase and land

This revision was landed with ongoing or failed builds.Jan 30 2023, 7:17 PM

Closed by commit rCOMM1dd0d74e03b3: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in…. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1dd0d74e03b3: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in….

Harbormaster completed remote builds in B15856: Diff 21638.Jan 30 2023, 7:25 PM

Revision Contents
Changeset List

Path

Size

web/

account/

siwe.react.js

18 lines

Diff 21544

View Options

[web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in `SIWE` componentClosedPublicActions