Page MenuHomePhabricator
Differential D6434

[lib] Introduce `reducePrimaryIdentityPublicKey` reducer
ClosedPublic
Actions

Authored by atul on Jan 28 2023, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 9 2024, 10:39 AM
Unknown Object (File)
Apr 5 2024, 12:29 AM
Unknown Object (File)
Apr 5 2024, 12:29 AM
Unknown Object (File)
Apr 5 2024, 12:29 AM
Unknown Object (File)
Apr 5 2024, 12:29 AM
Unknown Object (File)
Apr 5 2024, 12:29 AM
Unknown Object (File)
Apr 5 2024, 12:29 AM
Unknown Object (File)
Apr 5 2024, 12:28 AM
View All 44 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM932d057e9d68: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer
Summary

Introduce setPrimaryIdentityPublicKey action type and reducePrimaryIdentityPublicKey reducer.

setPrimaryIdentityPublicKey action will be dispatched in subsequent diffs to properly set the primaryIdentityPublicKey.

Depends on D6433

Test Plan

Will be tested by subsequent diffs/flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 28 2023, 3:58 PM
atul published this revision for review.Jan 28 2023, 4:00 PM
atul edited the summary of this revision. (Show Details)
atul added a parent revision: D6433: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.
Harbormaster completed remote builds in B15773: Diff 21515.Jan 28 2023, 4:12 PM
ashoat requested changes to this revision.Jan 28 2023, 5:30 PM
ashoat added inline comments.
lib/reducers/primary-identity-public-key-reducer.js
10 ↗(On Diff #21515)

I don't think we should introduce a reducer storing user data without handling logout, account deletion, and session invalidation

This revision now requires changes to proceed.Jan 28 2023, 5:30 PM
atul updated this revision to Diff 21541.Jan 29 2023, 4:18 PM

handle logout, account deletion, and session invalidation

atul updated this revision to Diff 21542.EditedJan 29 2023, 4:33 PM

hook up reducer to web/redux/redux-setup:reducer

Harbormaster completed remote builds in B15795: Diff 21541.Jan 29 2023, 4:33 PM
Harbormaster completed remote builds in B15796: Diff 21542.Jan 29 2023, 4:44 PM
atul updated this revision to Diff 21543.Jan 29 2023, 5:02 PM

add same sessionChange.cookieInvalidated check as reduceDeviceID

atul added a child revision: D6451: [web] Use Redux instead of `React.State` for `primaryIdentityPublicKey` in `SIWE` component.Jan 29 2023, 5:07 PM
Harbormaster completed remote builds in B15797: Diff 21543.Jan 29 2023, 5:17 PM
tomek accepted this revision.Jan 30 2023, 4:27 AM
tomek added 1 blocking reviewer(s): ashoat.
tomek added inline comments.
web/redux/primary-identity-public-key-reducer.js
12 ↗(On Diff #21543)

I don't think we should mix default and named imports, especially when reducePrimaryIdentityPublicKey is already exported.

19–22 ↗(On Diff #21543)

We should create a function that contains all these checks - we use it ina lot of places and missing any of them might have serious consequences. Could you create a task for it?

ashoat accepted this revision.Jan 30 2023, 9:47 AM
ashoat added inline comments.
web/redux/primary-identity-public-key-reducer.js
12 ↗(On Diff #21543)

Agree with this

19–22 ↗(On Diff #21543)

I think Flow won't be able to properly handle typing eg. action.payload within the conditional if you use a function

This revision is now accepted and ready to land.Jan 30 2023, 9:47 AM
atul added inline comments.Jan 30 2023, 9:48 AM
web/redux/primary-identity-public-key-reducer.js
12 ↗(On Diff #21543)

Yeah sorry, totally intended to cut the export default

atul updated this revision to Diff 21636.Jan 30 2023, 10:46 AM

remove export default

atul added inline comments.Jan 30 2023, 10:55 AM
web/redux/primary-identity-public-key-reducer.js
19–22 ↗(On Diff #21543)

https://linear.app/comm/issue/ENG-2881/create-function-to-check-if-actions-necessitate-clearing-user-data

Created task to track creation of function

This revision was landed with ongoing or failed builds.Jan 30 2023, 10:59 AM
Closed by commit rCOMM932d057e9d68: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM932d057e9d68: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.
Harbormaster completed remote builds in B15855: Diff 21636.Jan 30 2023, 11:01 AM

Revision Contents
Changeset List

Diff 21637

View Options

web/redux/primary-identity-public-key-reducer.js

Loading...
View Options

web/redux/redux-setup.js

Loading...