Details

Reviewers

ashoat
tomek

Commits

rCOMM1aae0e22e68d: [lib][web] Add `primaryIdentityPublicKey` entry to Redux

Summary

Will add actions and reducers and whatnot in subsequent diff. This is minimal change to include primaryIdentityPublicKey in Redux that doesn't break anything (to my knowledge).

Test Plan

Checked Redux DevTools on web and the primaryIdentityPublicKey appeared as expected. Also no flow errors.

Web:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 28 2023, 3:31 PM

atul published this revision for review.Jan 28 2023, 3:33 PM

atul edited the summary of this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B15772: Diff 21514.Jan 28 2023, 3:46 PM

make sure to persist on web

atul added a child revision: D6434: [lib] Introduce `reducePrimaryIdentityPublicKey` reducer.Jan 28 2023, 4:01 PM

Harbormaster completed remote builds in B15774: Diff 21516.Jan 28 2023, 4:14 PM

Passing back to you with question – not clear why we need to put this in Redux on native given it's already persisted by CommCoreModule

native/redux/redux-setup.js
135 ↗	(On Diff #21516)	I'm not sure we should be including this in Redux on `native`... isn't this handled by the JSI layer? I'd rather not have to worry about two values getting out of sync, but open to an argument for it

This revision now requires changes to proceed.Jan 28 2023, 5:29 PM

In D6433#192577, @ashoat wrote:

Passing back to you with question – not clear why we need to put this in Redux on native given it's already persisted by CommCoreModule

That's fair, was including on both web and native to keep things symmetrical (even if redundant on native) in case we want to reuse any logic or whatever... but will stick to just web for now.

web only

atul retitled this revision from [lib][web][native] Add `primaryIdentityPublicKey` entry to Redux to [lib][web] Add `primaryIdentityPublicKey` entry to Redux.Jan 29 2023, 4:01 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B15794: Diff 21540.Jan 29 2023, 4:16 PM

tomek accepted this revision.Jan 30 2023, 4:18 AM

tomek added 1 blocking reviewer(s): ashoat.

ashoat accepted this revision.Jan 30 2023, 9:48 AM

This revision is now accepted and ready to land.Jan 30 2023, 9:48 AM

rebase and land

Harbormaster completed remote builds in B15854: Diff 21621.Jan 30 2023, 10:07 AM

Closed by commit rCOMM1aae0e22e68d: [lib][web] Add `primaryIdentityPublicKey` entry to Redux (authored by atul). · Explain WhyJan 30 2023, 10:36 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1aae0e22e68d: [lib][web] Add `primaryIdentityPublicKey` entry to Redux.