Paths

Table of Contentst

Differential D6479

[lib] Inline threadSearchText
ClosedPublic
Actions

Authored by ashoat on Jan 31 2023, 5:07 AM.

Details

Reviewers

atul

Commits

rCOMM42d4f32a8f22: [lib] Inline threadSearchText

Summary

This function is only used from one place in the codebase. I want to separate it out into two parts – one for UserInfo fetching and another for the rest. That's because I want to pass the UserInfos through useENSNames.

Depends on D6478

Test Plan

Flow, and tested with the rest of the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 31 2023, 5:07 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 31 2023, 5:07 AM

ashoat added a child revision: D6480: [lib] Fetch ENS names in useThreadSearchIndex.Jan 31 2023, 5:08 AM

Harbormaster completed remote builds in B15879: Diff 21676.Jan 31 2023, 5:21 AM

ashoat requested review of this revision.Jan 31 2023, 5:21 AM

atul accepted this revision.Jan 31 2023, 9:49 AM

atul added inline comments.

lib/selectors/nav-selectors.js
89–94	I guess you could merge these

This revision is now accepted and ready to land.Jan 31 2023, 9:49 AM

ashoat added inline comments.Jan 31 2023, 12:05 PM

lib/selectors/nav-selectors.js
89–94	Don't know if that improves readability tbh

Closed by commit rCOMM42d4f32a8f22: [lib] Inline threadSearchText (authored by ashoat). · Explain WhyJan 31 2023, 12:06 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM42d4f32a8f22: [lib] Inline threadSearchText.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

nav-selectors.js

27 lines

shared/

thread-utils.js

29 lines

Diff 21676

View Options

lib/selectors/nav-selectors.js