Page MenuHomePhabricator
Differential D6477

[lib] Introduce useThreadSearchIndex hook
ClosedPublic
Actions

Authored by ashoat on Jan 31 2023, 4:55 AM.
Tags
None
Referenced Files
F5885526: D6477.diff
Thu, Apr 17, 3:50 AM
F5879982: D6477.diff
Thu, Apr 17, 2:05 AM
Unknown Object (File)
Mar 7 2025, 10:41 PM
Unknown Object (File)
Mar 7 2025, 4:38 PM
Unknown Object (File)
Mar 2 2025, 1:55 AM
Unknown Object (File)
Feb 27 2025, 10:47 PM
Unknown Object (File)
Feb 11 2025, 4:21 AM
Unknown Object (File)
Jan 31 2025, 8:42 AM
View All 75 Files
Subscribers
tomek

Details

Reviewers
atul
inka
Commits
rCOMM472a155c6620: [lib] Introduce useThreadSearchIndex hook
Summary

Converting this to a hook will make it easier to swap in ENS names.

Depends on D6476

Test Plan

Tested the two surfaces that currently use useSearchThreads: SidebarListModal and SubchannelsListModal on native

Screenshot 2023-01-31 at 7.55.34 AM.png (1×772 px, 88 KB)
Screenshot 2023-01-31 at 7.55.40 AM.png (1×768 px, 79 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 31 2023, 4:55 AM
Herald added a subscriber: tomek. · View Herald TranscriptJan 31 2023, 4:55 AM
ashoat added a child revision: D6478: [lib] Replace threadSearchIndex selector with useGlobalThreadSearchIndex hook.Jan 31 2023, 5:04 AM
Harbormaster completed remote builds in B15876: Diff 21673.Jan 31 2023, 5:09 AM
ashoat requested review of this revision.Jan 31 2023, 5:09 AM
ashoat edited the test plan for this revision. (Show Details)Jan 31 2023, 5:09 AM
ashoat added a reviewer: inka.
atul accepted this revision.Jan 31 2023, 9:47 AM
This revision is now accepted and ready to land.Jan 31 2023, 9:47 AM
Closed by commit rCOMM472a155c6620: [lib] Introduce useThreadSearchIndex hook (authored by ashoat). · Explain WhyJan 31 2023, 12:06 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM472a155c6620: [lib] Introduce useThreadSearchIndex hook.
ashoat added inline comments.Aug 8 2023, 6:50 AM
lib/hooks/search-threads.js
52

This was a big oversight. This map should have been memoized... failing to memoize it caused ENG-4605

Revision Contents
Changeset List

PathSize
lib/
hooks/
21 lines
selectors/
24 lines

Diff 21703

View Options

lib/hooks/search-threads.js

Loading...
View Options

lib/selectors/nav-selectors.js

Loading...