Paths

Table of Contentst

[lib] Introduce useThreadSearchIndex hook
ClosedPublic
Actions

Authored by ashoat on Jan 31 2023, 12:55 PM.

Details

Reviewers

atul
inka

Commits

rCOMM472a155c6620: [lib] Introduce useThreadSearchIndex hook

Summary

Converting this to a hook will make it easier to swap in ENS names.

Depends on D6476

Test Plan

Tested the two surfaces that currently use useSearchThreads: SidebarListModal and SubchannelsListModal on native

Screenshot 2023-01-31 at 7.55.34 AM.png (1×772 px, 88 KB)

Screenshot 2023-01-31 at 7.55.40 AM.png (1×768 px, 79 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 31 2023, 12:55 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 31 2023, 12:55 PM

ashoat added a child revision: D6478: [lib] Replace threadSearchIndex selector with useGlobalThreadSearchIndex hook.Jan 31 2023, 1:04 PM

Harbormaster completed remote builds in B15876: Diff 21673.Jan 31 2023, 1:09 PM

ashoat requested review of this revision.Jan 31 2023, 1:09 PM

ashoat edited the test plan for this revision. (Show Details)Jan 31 2023, 1:09 PM

ashoat added a reviewer: inka.

atul accepted this revision.Jan 31 2023, 5:47 PM

This revision is now accepted and ready to land.Jan 31 2023, 5:47 PM

Closed by commit rCOMM472a155c6620: [lib] Introduce useThreadSearchIndex hook. · Explain WhyJan 31 2023, 8:06 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM472a155c6620: [lib] Introduce useThreadSearchIndex hook.

ashoat added inline comments.Aug 8 2023, 1:50 PM

lib/hooks/search-threads.js
52	This was a big oversight. This `map` should have been memoized... failing to memoize it caused ENG-4605

Revision Contents
Changeset List

Path

Size

lib/

hooks/

search-threads.js

21 lines

selectors/

nav-selectors.js

24 lines

Diff 21703

View Options

lib/hooks/search-threads.js