[web] Pull `TraditionalLoginForm` out of `LoginForm` component
ClosedPublic
Actions

Authored by atul on Feb 1 2023, 1:04 PM.

Details

Reviewers

ashoat
tomek
ginsu
rohan

Commits

rCOMM54ca95a35fd0: [web] Pull `TraditionalLoginForm` out of `LoginForm` component

Summary

LoginForm was handling both "traditional" and SIWE login. In subsequent diffs we'll have a separate TraditionalLoginForm and SIWELoginForm component that are displayed conditionally.

Test Plan

Still a noop, both "traditional" and SIWE login continue to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 1 2023, 1:04 PM

atul published this revision for review.Feb 1 2023, 1:05 PM

atul edited the summary of this revision. (Show Details)

atul added inline comments.

web/account/log-in-form.react.js
38 ↗	(On Diff #21784)	I know we don't like these ternaries, removed in subsequent diff.

Assuming this is a simple move diff and blindly accepting

This revision is now accepted and ready to land.Feb 1 2023, 1:10 PM

This revision was landed with ongoing or failed builds.Feb 1 2023, 1:18 PM

Closed by commit rCOMM54ca95a35fd0: [web] Pull `TraditionalLoginForm` out of `LoginForm` component (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM54ca95a35fd0: [web] Pull `TraditionalLoginForm` out of `LoginForm` component.

Harbormaster completed remote builds in B15952: Diff 21784.Feb 1 2023, 1:23 PM

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.react.js

166 lines

	traditional-login-form.react.js
	log-in-form.react.js

143 lines

Diff 21789

View Options

web/account/log-in-form.react.js