Page MenuHomePhabricator
Differential D6512

[lib] Convert AddMembers/RemoveMembers robotext to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:30 PM
Unknown Object (File)
Sat, Dec 14, 1:30 PM
Unknown Object (File)
Sat, Dec 14, 1:30 PM
Unknown Object (File)
Sat, Dec 14, 1:30 PM
Unknown Object (File)
Sat, Dec 14, 1:29 PM
Unknown Object (File)
Sat, Dec 14, 1:23 PM
Unknown Object (File)
Nov 18 2024, 7:26 PM
Unknown Object (File)
Nov 16 2024, 7:37 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM691ad069529f: [lib] Convert AddMembers/RemoveMembers robotext to use EntityText
Summary

Depends on D6511

Test Plan

Looked at an AddMembers robotext on web and native, both from the perspective of the viewer and of somebody else

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 2:07 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 2:07 PM
ashoat added a child revision: D6513: [lib] Convert ChangeSettings robotext to use EntityText.Feb 1 2023, 2:08 PM
Harbormaster completed remote builds in B15971: Diff 21807.Feb 1 2023, 2:25 PM
ashoat requested review of this revision.Feb 1 2023, 2:25 PM
ashoat updated this revision to Diff 21815.Feb 1 2023, 3:39 PM

Handle RemoveMembers in the same diff since it's pretty much the same

ashoat retitled this revision from [lib] Convert AddMembers robotext to use EntityText to [lib] Convert AddMembers/RemoveMembers robotext to use EntityText.Feb 1 2023, 3:40 PM
ashoat added a child revision: D6515: [lib] Convert JoinThread/LeaveThread robotext to use EntityText.Feb 1 2023, 3:48 PM
Harbormaster completed remote builds in B15974: Diff 21815.Feb 1 2023, 4:04 PM
ashoat removed a child revision: D6515: [lib] Convert JoinThread/LeaveThread robotext to use EntityText.Feb 1 2023, 4:16 PM
ashoat updated this revision to Diff 21847.Feb 2 2023, 6:39 AM

basePluralize no longer takes baseCase

Harbormaster completed remote builds in B16003: Diff 21847.Feb 2 2023, 6:53 AM
atul accepted this revision.Feb 2 2023, 10:47 AM
This revision is now accepted and ready to land.Feb 2 2023, 10:47 AM
Closed by commit rCOMM691ad069529f: [lib] Convert AddMembers/RemoveMembers robotext to use EntityText (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM691ad069529f: [lib] Convert AddMembers/RemoveMembers robotext to use EntityText.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
21 lines
23 lines
utils/
16 lines

Diff 21815

View Options

lib/shared/messages/add-members-message-spec.js

Loading...
View Options

lib/shared/messages/remove-members-message-spec.js

Loading...
View Options

lib/utils/entity-text.js

Loading...