[lib] Convert ChangeSettings robotext to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 2:08 PM.

Details

Reviewers

atul

Commits

rCOMM3e3b36eb26bb: [lib] Convert ChangeSettings robotext to use EntityText

Summary

Depends on D6512

Test Plan

Looked at a ChangeSettings robotext on web and native, both from the perspective of the viewer and of somebody else

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 2:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 2:08 PM

Harbormaster completed remote builds in B15972: Diff 21808.Feb 1 2023, 2:26 PM

ashoat requested review of this revision.Feb 1 2023, 2:26 PM

ashoat added a child revision: D6514: [lib] Convert ChangeRole robotext to use EntityText.Feb 1 2023, 3:37 PM

Don't include "this" as it's handled by ThreadEntity now

Harbormaster completed remote builds in B15978: Diff 21819.Feb 1 2023, 5:20 PM

atul accepted this revision.Feb 2 2023, 10:53 AM

This revision is now accepted and ready to land.Feb 2 2023, 10:53 AM

Closed by commit rCOMM3e3b36eb26bb: [lib] Convert ChangeSettings robotext to use EntityText (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3e3b36eb26bb: [lib] Convert ChangeSettings robotext to use EntityText.

ashoat mentioned this in D6575: [lib] Render EntityText directly from notifRobotextForMessageInfo.Feb 5 2023, 7:39 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

change-settings-message-spec.js

32 lines

Diff 21819

View Options

lib/shared/messages/change-settings-message-spec.js

[lib] Convert ChangeSettings robotext to use EntityTextClosedPublicActions