[lib] Convert CreateSidebar/CreateThread robotext to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 5:59 PM.

Details

Reviewers

atul

Commits

rCOMM5fd8fb36ef78: [lib] Convert CreateSidebar/CreateThread robotext to use EntityText

Summary

Depends on D6517

Test Plan

Looked at a CreateSidebar robotext on web and native, both from the perspective of the viewer and of somebody else

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 5:59 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 5:59 PM

ashoat added a child revision: D6519: [lib] Convert CreateSubThread robotext to use EntityText.Feb 1 2023, 5:59 PM

Harbormaster completed remote builds in B15983: Diff 21824.Feb 1 2023, 6:13 PM

ashoat requested review of this revision.Feb 1 2023, 6:13 PM

atul accepted this revision.Feb 2 2023, 10:59 AM

This revision is now accepted and ready to land.Feb 2 2023, 10:59 AM

Closed by commit rCOMM5fd8fb36ef78: [lib] Convert CreateSidebar/CreateThread robotext to use EntityText (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5fd8fb36ef78: [lib] Convert CreateSidebar/CreateThread robotext to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

create-sidebar-message-spec.js

29 lines

create-thread-message-spec.js

40 lines

Diff 21824

View Options

lib/shared/messages/create-sidebar-message-spec.js