Differential D6519

[lib] Convert CreateSubThread robotext to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 5:59 PM.

Details

Reviewers

atul

Commits

rCOMM6ae3b5c23492: [lib] Convert CreateSubThread robotext to use EntityText

Summary

To make this one work, I had to introduce a new field on ThreadEntity: subchannel

Depends on D6518

Test Plan

Looked at a CreateSubThread robotext on web and native, both from the perspective of the viewer and of somebody else

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/ens

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 5:59 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 5:59 PM

ashoat retitled this revision from [lib] Convert CreateSubtThread robotext to use EntityText to [lib] Convert CreateSubThread robotext to use EntityText.Feb 1 2023, 6:08 PM

ashoat added a child revision: D6520: [lib] Convert UpdateRelationship robotext to use EntityText.Feb 1 2023, 6:09 PM

Harbormaster completed remote builds in B15984: Diff 21825.Feb 1 2023, 6:14 PM

ashoat requested review of this revision.Feb 1 2023, 6:14 PM

atul accepted this revision.Feb 2 2023, 10:59 AM

This revision is now accepted and ready to land.Feb 2 2023, 10:59 AM

Closed by commit rCOMM6ae3b5c23492: [lib] Convert CreateSubThread robotext to use EntityText (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6ae3b5c23492: [lib] Convert CreateSubThread robotext to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

create-sub-thread-message-spec.js

34 lines

utils/

entity-text.js

7 lines

Diff 21825

View Options

lib/shared/messages/create-sub-thread-message-spec.js