Paths

Table of Contentst

Differential D6529

[lib] Use term "channel" in threadNoun
ClosedPublic
Actions

Authored by ashoat on Feb 2 2023, 8:45 AM.

Tags

None

Referenced Files

	F3503592: D6529.id21861.diff
	Fri, Dec 20, 5:45 AM

	F3500030: D6529.diff
	Fri, Dec 20, 12:44 AM

	Unknown Object (File)
	Nov 18 2024, 7:29 PM

	Unknown Object (File)
	Nov 18 2024, 7:28 PM

	Unknown Object (File)
	Nov 18 2024, 7:28 PM

	Unknown Object (File)
	Nov 18 2024, 7:28 PM

	Unknown Object (File)
	Oct 29 2024, 4:20 PM

	Unknown Object (File)
	Oct 29 2024, 4:20 PM

Subscribers

Details

Reviewers

Commits

rCOMM5cfc7a2966c7: [lib] Use term "channel" in threadNoun

Summary

This diff updates our copy to use the term "channel" when referring to a chat inside a community. This will be used in robotext and notifs.

Depends on D6528

Test Plan

Flow and careful reading through the code. threadNoun is only used in two places – once in getNameForThreadEntity in entity-text.js, and once in notifTextForSubthreadCreation. I made sure that the relevant robotexts that end up using threadNoun through ET were updated

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 2 2023, 8:45 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 2 2023, 8:45 AM

Harbormaster completed remote builds in B16016: Diff 21861.Feb 2 2023, 9:00 AM

ashoat requested review of this revision.Feb 2 2023, 9:00 AM

atul accepted this revision.Feb 2 2023, 11:07 AM

This revision is now accepted and ready to land.Feb 2 2023, 11:07 AM

Closed by commit rCOMM5cfc7a2966c7: [lib] Use term "channel" in threadNoun (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5cfc7a2966c7: [lib] Use term "channel" in threadNoun.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

16 lines

Diff 21861

lib/shared/thread-utils.js

Loading...