Page MenuHomePhabricator

[keyserver] Fix "added username and username" issue when adding user
ClosedPublic

Authored by ashoat on Feb 5 2023, 7:42 AM.
Tags
None
Referenced Files
F3505394: D6616.id22036.diff
Fri, Dec 20, 1:18 PM
F3504676: D6616.diff
Fri, Dec 20, 10:00 AM
Unknown Object (File)
Nov 18 2024, 10:38 PM
Unknown Object (File)
Nov 15 2024, 1:52 AM
Unknown Object (File)
Nov 15 2024, 1:51 AM
Unknown Object (File)
Nov 15 2024, 1:51 AM
Unknown Object (File)
Nov 15 2024, 1:51 AM
Unknown Object (File)
Oct 29 2024, 1:29 PM
Subscribers

Details

Summary

I noticed that sometimes when I added somebody to a chat, their name would be printed twice in the robotext and the notif.

I investigated and found that it was because we're determining addedMemberIDs incorrectly in this code, as we're including any rows in the changeset for any threads. It's possible for adding somebody to a thread to cause their membership row to change for another thread, eg. a subthread they are already in.

To avoid this we could also check intent, but I figured checking threadID was more appropriate.

Test Plan

Confirmed that the "added username and username" probably went away in both robotext and notifs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable