Page MenuHomePhabricator

Update eslint-plugin-import to 2.27.5
ClosedPublic

Authored by ashoat on Feb 11 2023, 12:00 PM.
Tags
None
Referenced Files
F3505766: D6693.largetrue.diff
Fri, Dec 20, 2:31 PM
F3505731: D6693.id22336.diff
Fri, Dec 20, 2:25 PM
F3505437: D6693.id22340.diff
Fri, Dec 20, 1:28 PM
F3504709: D6693.diff
Fri, Dec 20, 10:12 AM
F3503671: D6693.id22368.diff
Fri, Dec 20, 6:07 AM
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Mon, Dec 16, 12:52 AM
Unknown Object (File)
Mon, Dec 16, 12:50 AM
Subscribers

Details

Summary

I updated this because I thought I was using it right but it wasn't working. Turns out I was using it wrong, but figured it doesn't hurt to upgrade anyways.

Depends on D6692

Test Plan
  1. No breaking changes in the CHANGELOG.md file
  2. Ran yarn eslint:fix in the root of the repo and confirmed no changes occurred

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2023, 12:14 PM
Harbormaster failed remote builds in B16334: Diff 22336!

This update caused a lot of changes. I can't really see what up from the CHANGELOG... some theories are this, this, or this.

This will pollute Git history but I couldn't find an easy way out unfortunately

(All of the JS changes in this diff are irrelevant changes to import ordering and grouping)

Again checked a handful of files, but effectively accepting blind

This revision is now accepted and ready to land.Feb 12 2023, 3:46 PM
This revision was automatically updated to reflect the committed changes.