Page MenuHomePhabricator
Differential D6724

[web] Include `primaryIdentityPublicKey` when logging in from `web`
ClosedPublic
Actions

Authored by atul on Feb 13 2023, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:40 AM
Unknown Object (File)
Tue, Nov 5, 2:09 AM
Unknown Object (File)
Oct 15 2024, 4:41 PM
Unknown Object (File)
Oct 5 2024, 7:36 PM
Unknown Object (File)
Oct 2 2024, 8:15 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM54753f8c63de: [web] Include `primaryIdentityPublicKey` when logging in from `web`
Summary

We're now passing primaryIdentityPublicKey to logInResponder when we log in from both native and web.

Test Plan

primaryIdentityPublicKey appears in request:

8fbf6f.png (212×1 px, 65 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 13 2023, 4:51 PM
atul published this revision for review.Feb 13 2023, 4:52 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/account/log-in-form.react.js
28–33 ↗(On Diff #22511)

We want primaryIdentityPublicKey to be in dep list so we can re-fetch primaryIdentityPublicKey once LOG_OUT_SUCCESS gets processed and unsets primaryIdentityPublicKey.

Without these changes, primaryIdentityPublicKey would be null once LOG_OUT_SUCCESS gets processed and leaves the "Log in" button permanently disabled.

Harbormaster completed remote builds in B16465: Diff 22511.Feb 13 2023, 5:07 PM
ashoat accepted this revision.Feb 13 2023, 6:26 PM
This revision is now accepted and ready to land.Feb 13 2023, 6:26 PM
atul updated this revision to Diff 22518.Feb 13 2023, 10:17 PM

rebase before landing

Harbormaster completed remote builds in B16472: Diff 22518.Feb 13 2023, 10:31 PM
Closed by commit rCOMM54753f8c63de: [web] Include `primaryIdentityPublicKey` when logging in from `web` (authored by atul). · Explain WhyFeb 13 2023, 10:41 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM54753f8c63de: [web] Include `primaryIdentityPublicKey` when logging in from `web`.

Revision Contents
Changeset List

PathSize
web/
account/
13 lines
17 lines

Diff 22518

View Options

web/account/log-in-form.react.js

Loading...
View Options

web/account/traditional-login-form.react.js

Loading...