Differential D6685

[native] [ENG-2207] Too big notifications when the message is long
ClosedPublic
Actions

Authored by • kuba on Feb 10 2023, 4:00 AM.

Details

Reviewers

tomek

Commits

rCOMMe617274bbf45: [native] [ENG-2207] Too big notifications when the message is long

Summary

Long messages lead to in-app notifications taking up almost half the screen on iOS and Android.

Screenshot_1676029164.png (2×1 px, 137 KB)

Test Plan

I tested new behavior on both operating systems. Now it shows only the first line of the message.

Screenshot_1676029334.png (2×1 px, 150 KB)

Diff Detail

Repository

rCOMM Comm

Branch

kuba/notifications-error

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Feb 10 2023, 4:00 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 10 2023, 4:00 AM

• kuba retitled this revision from [native] Too big notifications when the message is long to [native] [ENG-2207] Too big notifications when the message is long.Feb 10 2023, 4:05 AM

• kuba edited the summary of this revision. (Show Details)

• kuba edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B16324: Diff 22326.Feb 10 2023, 4:15 AM

• kuba requested review of this revision.Feb 10 2023, 4:15 AM

tomek requested changes to this revision.Feb 13 2023, 4:50 AM

tomek added inline comments.

native/push/in-app-notif.react.js
25 ↗	(On Diff #22326)	Why is this character removed? Is there a difference in how the notif looks like when it is present?
28 ↗	(On Diff #22326)	I think it might be safer to not include a nested array

This revision now requires changes to proceed.Feb 13 2023, 4:50 AM

Removing nested array

Fixed Tomek's comments.

native/push/in-app-notif.react.js
25 ↗	(On Diff #22326)	Previously it was responsible for a new line between Title and Content. Now it's handled by covering message in <SingleLine> component.