Paths

Table of Contentst

Differential D6523

[services] Tunnelbroker - Add disable `deviceID` format validation config parameter
ClosedPublic
Actions

Authored by • max on Feb 2 2023, 4:42 AM.

Tags

None

Referenced Files

	F2028684: D6523.id22639.diff
	Mon, Jun 17, 11:07 PM

	F2028683: D6523.id21842.diff
	Mon, Jun 17, 11:07 PM

	Unknown Object (File)
	Thu, Jun 13, 10:59 PM

	Unknown Object (File)
	Tue, Jun 11, 3:07 PM

	Unknown Object (File)
	Tue, Jun 11, 8:24 AM

	Unknown Object (File)
	Tue, Jun 11, 8:24 AM

	Unknown Object (File)
	Mon, Jun 10, 3:03 PM

	Unknown Object (File)
	Sun, Jun 9, 8:06 PM

View All 57 Files

Subscribers

Details

Reviewers

• jon
bartek

Commits

rCOMM5a05f25ddd00: [services] Tunnelbroker - Add disable `deviceID` format validation config…

Summary

This diff introduces adding the sessions.disable_deviceid_validation config flag to disable a deviceID format validation in Tunnelbroker.
We are disabling the validation of the deviceID format for using the Tunnelbroker as a Redis replacement, in this case, the deviceID format will be different and we should not validate it.

Linear task: ENG-2640

Test Plan

CI checks are successfully passed.
This flag is used in the following D6523.

Manual testing:
Adding the disable_deviceid_validation flag to the [sessions] section of the config file results in a true return from the isParameterSet('sessions.disable_deviceid_validation') function call.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Feb 2 2023, 4:42 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptFeb 2 2023, 4:42 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a child revision: D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.Feb 2 2023, 4:50 AM

• max edited the summary of this revision. (Show Details)Feb 2 2023, 4:55 AM

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: bartek.

• max edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B15998: Diff 21842.Feb 2 2023, 4:56 AM

• max published this revision for review.Feb 2 2023, 4:59 AM

• max mentioned this in D6524: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.

• jon accepted this revision.Feb 2 2023, 10:18 AM

This revision is now accepted and ready to land.Feb 2 2023, 10:18 AM

Closed by commit rCOMM5a05f25ddd00: [services] Tunnelbroker - Add disable `deviceID` format validation config… (authored by • max). · Explain WhyFeb 15 2023, 3:24 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM5a05f25ddd00: [services] Tunnelbroker - Add disable `deviceID` format validation config….

• max mentioned this in rCOMM044b8239d2c4: [services] Tunnelbroker - Skipping `deviceID` validation in tools function.Feb 15 2023, 4:15 PM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

libcpp/

src/

Tools/

ConfigManager.h

1 line

ConfigManager.cpp

5 lines

Diff 22639

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.h

Loading...

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.cpp

Loading...