Page MenuHomePhabricator
Differential D6783

Update Prettier
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 9:56 AM.
Tags
None
Referenced Files
F3389392: D6783.id22738.diff
Fri, Nov 29, 6:55 PM
F3388908: D6783.diff
Fri, Nov 29, 4:35 PM
Unknown Object (File)
Thu, Nov 14, 4:46 AM
Unknown Object (File)
Oct 27 2024, 5:51 PM
Unknown Object (File)
Oct 24 2024, 8:34 AM
Unknown Object (File)
Oct 23 2024, 10:12 AM
Unknown Object (File)
Oct 23 2024, 10:12 AM
Unknown Object (File)
Oct 22 2024, 5:28 PM
View All Files
Subscribers
None

Details

Reviewers
tomek
atul
• jon
Commits
rCOMMc6ae007716eb: Update Prettier
Summary

Our current version of Prettier was printing an error when parsing import.meta.url. Upgrading it resolving the problem.

This diff was generated by updating the version of Prettier in package.json, running yarn cleaninstall, and then running prettier --write . from the root of the repo. After that, I just had a couple of places I need to manually fix up.

Test Plan

Flow + ESLint

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 20 2023, 9:56 AM
ashoat added a child revision: D6784: [keyserver] Fix rust-node-addon after deprecation of --experimental-specifier-resolution=node.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 20 2023, 10:00 AM
Harbormaster failed remote builds in B16623: Diff 22730!
ashoat requested review of this revision.Feb 20 2023, 10:31 AM
atul accepted this revision.Feb 20 2023, 10:36 AM

Accepting to unblock.

Is all the Prettier config from before "making" it through to the updated version?

For example, in the following examples I much prefer the "before" formatting. The "after" formatting reminds me of the clang-format-style formatting.

0fe7d0.png (1×3 px, 419 KB)

This revision is now accepted and ready to land.Feb 20 2023, 10:36 AM
ashoat added a comment.Feb 20 2023, 11:26 AM
In D6783#201638, @atul wrote:

Accepting to unblock.

Is all the Prettier config from before "making" it through to the updated version?

For example, in the following examples I much prefer the "before" formatting. The "after" formatting reminds me of the clang-format-style formatting.

0fe7d0.png (1×3 px, 419 KB)

Prettier config is unchanged. I'm pretty sure it's still making it through. I agree with your aesthetic preferences, but I looked through the list of options and couldn't find anything that would fix this for us...

ashoat updated this revision to Diff 22738.Feb 20 2023, 11:47 AM

Rebase on D6785 to fix iOS CI build

ashoat added a parent revision: D6785: [native] Fix Buildkite iOS build to work from inside Nix.Feb 20 2023, 11:47 AM
Harbormaster completed remote builds in B16630: Diff 22738.Feb 20 2023, 12:08 PM
Closed by commit rCOMMc6ae007716eb: Update Prettier (authored by ashoat). · Explain WhyFeb 20 2023, 12:25 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMc6ae007716eb: Update Prettier.
ashoat mentioned this in D9716: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run Prettier on flow-typed folders.Nov 5 2023, 6:57 AM
ashoat mentioned this in rCOMM9f0564e4c88f: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run….Nov 27 2023, 3:25 PM

Large Diff

This large diff affects 242 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
.buildkite/
2 lines
keyserver/
8 lines
src/
creators/
18 lines
12 lines
27 lines
cron/
6 lines
deleters/
12 lines
fetchers/
15 lines
15 lines
5 lines
push/
6 lines
responders/
7 lines
15 lines
13 lines
18 lines
socket/
54 lines
updaters/
23 lines
6 lines
39 lines
6 lines
5 lines
uploads/
6 lines
landing/
10 lines
5 lines
6 lines
lib/
actions/
58 lines
20 lines
173 lines
349 lines
16 lines
32 lines
50 lines
86 lines
199 lines
96 lines
278 lines
components/
7 lines
5 lines
7 lines
hooks/
11 lines
reducers/
13 lines
91 lines
41 lines
selectors/
27 lines
13 lines
110 lines
25 lines
7 lines
67 lines
43 lines
222 lines
74 lines
35 lines
shared/
6 lines
15 lines
12 lines
36 lines
socket/
7 lines
7 lines
7 lines
7 lines
97 lines
types/
5 lines
5 lines
utils/
18 lines
5 lines
39 lines
7 lines
7 lines
12 lines
15 lines
10 lines
3 lines
native/
account/
7 lines
7 lines
16 lines
calendar/
8 lines
15 lines
7 lines
chat/
6 lines
7 lines
32 lines
5 lines
10 lines
8 lines
8 lines
27 lines
10 lines
7 lines
7 lines
7 lines
8 lines
5 lines
14 lines
9 lines
3 lines
15 lines
5 lines
14 lines
6 lines
7 lines
9 lines
6 lines
settings/
5 lines
7 lines
9 lines
7 lines
9 lines
9 lines
7 lines
9 lines
15 lines
9 lines
7 lines
5 lines
15 lines
9 lines
17 lines
45 lines
7 lines
26 lines
8 lines
5 lines
6 lines
7 lines
12 lines
9 lines
5 lines
32 lines
components/
17 lines
11 lines
7 lines
7 lines
8 lines
5 lines
5 lines
7 lines
18 lines
7 lines
7 lines
7 lines
data/
12 lines
input/
21 lines
5 lines
keyboard/
7 lines
7 lines
5 lines
markdown/
5 lines
5 lines
media/
4 lines
13 lines
20 lines
7 lines
4 lines
20 lines
6 lines
7 lines
7 lines
18 lines
9 lines
41 lines
navigation/
6 lines
5 lines
10 lines
183 lines
5 lines
5 lines
22 lines
5 lines
10 lines
5 lines
profile/
35 lines
7 lines
9 lines
7 lines
7 lines
12 lines
9 lines
10 lines
push/
3 lines
21 lines
redux/
7 lines
12 lines
5 lines
selectors/
29 lines
72 lines
27 lines
7 lines
staff/
6 lines
themes/
46 lines
tooltip/
3 lines
7 lines
2 lines
services/
18 lines
electron-update-server/
flow-typed/
npm/
12 lines
shared/
protos/
_generated/
1 line
web/
account/
6 lines
calendar/
21 lines
chat/
47 lines
9 lines
8 lines
7 lines
7 lines
3 lines
7 lines
relationship-prompt/
5 lines
5 lines
8 lines
18 lines
11 lines
components/
8 lines
5 lines
6 lines
input/
27 lines
5 lines
markdown/
5 lines
media/
4 lines
4 lines
26 lines
11 lines
modals/
history/
7 lines
7 lines
6 lines
8 lines
threads/
create/
10 lines
steps/
6 lines
members/
8 lines
notifications/
6 lines
settings/
12 lines
sidebars/
7 lines
redux/
5 lines
selectors/
21 lines
69 lines
6 lines
56 lines
36 lines
settings/
relationship/
8 lines
sidebar/
5 lines
16 lines
10 lines
7 lines
7 lines

Diff 22741

View Options

.buildkite/tunnelbroker_client.yml

View Options

keyserver/docker-compose.yml

View Options

keyserver/src/creators/account-creator.js

View Options

keyserver/src/creators/message-creator.js

View Options

keyserver/src/creators/thread-creator.js

View Options

keyserver/src/cron/daily-updates.js

View Options

keyserver/src/deleters/thread-deleters.js

View Options

keyserver/src/fetchers/message-fetchers.js

View Options

keyserver/src/fetchers/thread-permission-fetchers.js

View Options

keyserver/src/fetchers/upload-fetchers.js

View Options

keyserver/src/push/send.js

View Options

keyserver/src/responders/entry-responders.js

View Options

keyserver/src/responders/message-responders.js

View Options

keyserver/src/responders/user-responders.js

View Options

keyserver/src/responders/website-responders.js

View Options

keyserver/src/socket/socket.js

View Options

keyserver/src/updaters/activity-updaters.js

View Options

keyserver/src/updaters/relationship-updaters.js

View Options

keyserver/src/updaters/thread-permission-updaters.js

View Options

keyserver/src/updaters/thread-updaters.js

View Options

keyserver/src/updaters/upload-updaters.js

View Options

keyserver/src/uploads/media-utils.js

View Options

landing/investor-data.js

View Options

landing/siwe.react.js

View Options

landing/subscription-form.react.js

View Options

lib/actions/activity-actions.js

View Options

lib/actions/device-actions.js

View Options

lib/actions/entry-actions.js

View Options

lib/actions/message-actions.js

View Options

lib/actions/message-report-actions.js

View Options

lib/actions/relationship-actions.js

View Options

lib/actions/report-actions.js

View Options

lib/actions/siwe-actions.js

View Options

lib/actions/thread-actions.js

View Options

lib/actions/upload-actions.js

View Options

lib/actions/user-actions.js

View Options

lib/components/connected-wallet-info.react.js

View Options

lib/components/ens-cache-provider.react.js

View Options

lib/components/modal-provider.react.js

View Options

lib/hooks/disconnected-bar.js

View Options

lib/reducers/master-reducer.js

View Options

lib/reducers/message-reducer.js

View Options

lib/reducers/message-reducer.test.js

View Options

lib/selectors/account-selectors.js

View Options

lib/selectors/calendar-filter-selectors.js

View Options

lib/selectors/chat-selectors.js

View Options

lib/selectors/loading-selectors.js

View Options

lib/selectors/nav-selectors.js

View Options

lib/selectors/relationship-selectors.js

View Options

lib/selectors/server-calls.js

View Options

lib/selectors/socket-selectors.js

View Options

lib/selectors/thread-selectors.js

View Options

lib/selectors/user-selectors.js

View Options

lib/shared/entry-utils.js

View Options

lib/shared/markdown.js

View Options

lib/shared/markdown.test.js

View Options

lib/shared/thread-utils.js

View Options

lib/socket/api-request-handler.react.js

View Options

lib/socket/calendar-query-handler.react.js

View Options

lib/socket/report-handler.react.js

View Options

lib/socket/request-response-handler.react.js

View Options

lib/socket/socket.react.js

View Options

lib/types/account-types.js

View Options

lib/types/relationship-types.js

View Options

lib/utils/action-logger.js

View Options

lib/utils/action-utils.js

View Options

lib/utils/call-server-endpoint.js

View Options

lib/utils/date-utils.js

View Options

lib/utils/entity-helpers.js

View Options

lib/utils/message-ops-utils.js

View Options

lib/utils/message-ops-utils.test.js

View Options

lib/utils/objects.js

View Options

lib/utils/siwe-utils.js

View Options

native/account/log-in-panel.react.js

View Options

native/account/register-panel.react.js

View Options

native/account/siwe-panel.react.js

View Options

native/calendar/calendar.react.js

View Options

native/calendar/entry.react.js

View Options

native/calendar/section-footer.react.js

View Options

native/chat/chat-context-provider.react.js

View Options

native/chat/chat-header.react.js

View Options

native/chat/chat-input-bar.react.js

View Options

native/chat/chat-item-height-measurer.react.js

View Options

native/chat/chat-list.react.js

View Options

native/chat/chat-thread-list-see-more-sidebars.react.js

View Options

native/chat/chat-thread-list-sidebar.react.js

View Options

native/chat/chat-thread-list.react.js

View Options

native/chat/compose-subchannel.react.js

View Options

native/chat/compose-thread-button.react.js

View Options

native/chat/composed-message.react.js

View Options

native/chat/failed-send.react.js

View Options

native/chat/inline-engagement.react.js

View Options

native/chat/inner-robotext-message.react.js

View Options

native/chat/message-list-container.react.js

View Options

native/chat/message-list-header-title.react.js

View Options

native/chat/message-list-types.js

View Options

native/chat/message-list.react.js

View Options

native/chat/message-press-responder-context.js

View Options

native/chat/multimedia-message-multimedia.react.js

View Options

native/chat/multimedia-message-tooltip-button.react.js

View Options

native/chat/multimedia-message.react.js

View Options

native/chat/new-messages-pill.react.js

View Options

native/chat/robotext-message-tooltip-button.react.js

View Options

native/chat/settings/add-users-modal.react.js

View Options

native/chat/settings/color-selector-modal.react.js

View Options

native/chat/settings/compose-subchannel-modal.react.js

View Options

native/chat/settings/delete-thread.react.js

View Options

native/chat/settings/thread-settings-color.react.js

View Options

native/chat/settings/thread-settings-description.react.js

View Options

native/chat/settings/thread-settings-edit-relationship.react.js

View Options

native/chat/settings/thread-settings-home-notifs.react.js

View Options

native/chat/settings/thread-settings-leave-thread.react.js

View Options

native/chat/settings/thread-settings-member.react.js

View Options

native/chat/settings/thread-settings-name.react.js

View Options

native/chat/settings/thread-settings-parent.react.js

View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

View Options

native/chat/settings/thread-settings-push-notifs.react.js

View Options

native/chat/settings/thread-settings.react.js

View Options

native/chat/sidebar-list-modal.react.js

View Options

native/chat/subchannel-item.react.js

View Options

native/chat/subchannels-list-modal.react.js

View Options

native/chat/swipeable-message.react.js

View Options

native/chat/text-message-markdown-context.js

View Options

native/chat/text-message-tooltip-button.react.js

View Options

native/chat/text-message.react.js

View Options

native/chat/thread-list-modal.react.js

View Options

native/chat/thread-settings-button.react.js

View Options

native/chat/thread-settings-header-title.react.js

View Options

native/chat/utils.js

View Options

native/components/clearable-text-input.react.ios.js

View Options

native/components/clearable-text-input.react.js

View Options

native/components/keyboard-avoiding-view.react.js

View Options

native/components/link-button.react.js

View Options

native/components/node-height-measurer.react.js

View Options

native/components/selectable-text-input.react.ios.js

View Options

native/components/selectable-text-input.react.js

View Options

native/components/swipeable.js

View Options

native/components/tag-input.react.js

View Options

native/components/thread-list-thread.react.js

View Options

native/components/thread-list.react.js

View Options

native/components/user-list-user.react.js

View Options

native/data/sqlite-data-handler.js

View Options

native/input/input-state-container.react.js

View Options

native/input/input-state.js

View Options

native/keyboard/keyboard-input-host.react.js

View Options

native/keyboard/keyboard-state-container.react.js

View Options

native/keyboard/keyboard-state.js

View Options

native/markdown/markdown-context.js

View Options

native/markdown/markdown-spoiler-context.js

View Options

native/media/blob-utils.js

View Options

native/media/camera-modal.react.js

View Options

native/media/file-utils.js

View Options

native/media/image-modal.react.js

View Options

native/media/image-utils.js

View Options

native/media/media-gallery-keyboard.react.js

View Options

native/media/media-utils.js

View Options

native/media/multimedia.react.js

View Options

native/media/remote-image.react.js

View Options

native/media/save-media.js

View Options

native/media/send-media-button.react.js

View Options

native/media/video-playback-modal.react.js

View Options

native/navigation/app-navigator.react.js

View Options

native/navigation/community-drawer-item-community.react.js

View Options

native/navigation/community-drawer-item.react.js

View Options

native/navigation/nav-selectors.js

View Options

native/navigation/navigation-context.js

View Options

native/navigation/overlay-context.js

View Options

native/navigation/overlay-navigator.react.js

View Options

native/navigation/root-navigator-context.js

View Options

native/navigation/root-navigator.react.js

View Options

native/navigation/route-names.js

View Options

native/profile/appearance-preferences.react.js

View Options

native/profile/custom-server-modal.react.js

View Options

native/profile/default-notifications-preferences.react.js

View Options

native/profile/edit-password.react.js

View Options

native/profile/profile-header.react.js

View Options

native/profile/profile-screen.react.js

View Options

native/profile/relationship-list-item.react.js

View Options

native/profile/relationship-list.react.js

View Options

native/push/ios.js

View Options

native/push/push-handler.react.js

View Options

native/redux/connectivity-updater.react.js

View Options

native/redux/redux-setup.js

View Options

native/root-context.js

View Options

native/selectors/account-selectors.js

View Options

native/selectors/message-selectors.js

View Options

native/selectors/socket-selectors.js

View Options

native/socket.react.js

View Options

native/staff/staff-context.provider.react.js

View Options

native/themes/colors.js

View Options

native/tooltip/tooltip-context.react.js

View Options

native/tooltip/tooltip.react.js

View Options

services/docker-compose.yml

View Options

services/electron-update-server/flow-typed/npm/express_v4.17.x.js

View Options

shared/protos/_generated/.clang-format

View Options

web/account/log-in-form.react.js

View Options

web/calendar/entry.react.js

View Options

web/chat/chat-input-bar.react.js

View Options

web/chat/chat-message-list.react.js

View Options

web/chat/chat-thread-list.react.js

View Options

web/chat/composed-message.react.js

View Options

web/chat/failed-send.react.js

View Options

web/chat/message-list-types.js

View Options

web/chat/multimedia-message.react.js

View Options

web/chat/relationship-prompt/relationship-prompt.js

View Options

web/chat/robotext-message.react.js

View Options

web/chat/thread-list-provider.js

View Options

web/chat/tooltip-provider.js

View Options

web/chat/typeahead-tooltip.react.js

View Options

web/components/enum-settings-option-info.react.js

View Options

web/components/menu-item.react.js

View Options

web/components/search.react.js

View Options

web/input/input-state-container.react.js

View Options

web/input/input-state.js

View Options

web/markdown/markdown-spoiler.react.js

View Options

web/media/blob-utils.js

View Options

web/media/media-utils.js

View Options

web/media/multimedia-modal.react.js

View Options

web/menu-provider.react.js

View Options

web/modals/history/history-entry.react.js

View Options

web/modals/history/history-modal.react.js

View Options

web/modals/input.react.js

View Options

web/modals/search-modal.react.js

View Options

web/modals/threads/create/compose-subchannel-modal.react.js

View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

View Options

web/modals/threads/members/add-members-list-content.react.js

View Options

web/modals/threads/notifications/notifications-modal.react.js

View Options

web/modals/threads/settings/thread-settings-modal.react.js

View Options

web/modals/threads/sidebars/sidebar.react.js

View Options

web/redux/nav-reducer.js

View Options

web/selectors/account-selectors.js

View Options

web/selectors/chat-selectors.js

View Options

web/selectors/entry-selectors.js

View Options

web/selectors/nav-selectors.js

View Options

web/selectors/socket-selectors.js

View Options

web/settings/relationship/add-users-list-item.react.js

View Options

web/sidebar/community-drawer-item-community.react.js

View Options

web/sidebar/community-drawer-item-handlers.react.js

View Options

web/sidebar/community-drawer-item.react.js

View Options

web/socket.react.js