Details

Reviewers

atul
• jon

Commits

rCOMM4adee5e8f27e: [native] Fix Buildkite iOS build to work from inside Nix

Summary

We need the same patch we use in native/package.json for yarn react-native and yarn expo.

Test Plan

Let's see if this diff's Buildkite build succeeds :)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 20 2023, 10:47 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 20 2023, 10:47 AM

atul published this revision for review.Feb 20 2023, 10:50 AM

Harbormaster failed remote builds in B16625: Diff 22733!Feb 20 2023, 10:50 AM

Move $PATH hack to package.json. I suspect Buildkite is doing something wonky

Harbormaster failed remote builds in B16627: Diff 22735!Feb 20 2023, 11:31 AM

Seeing this issue because macOS's cp command is in /bin, and so we end up using the GNU one instead

This revision updates us to prefix $PATH with not just /usr/bin, but also /bin, so that we have access to BSD cp

It worked! Adding /bin to all of the places we prefix /usr/bin for future-proofing

Harbormaster completed remote builds in B16628: Diff 22736.Feb 20 2023, 11:47 AM

ashoat mentioned this in D6783: Update Prettier.Feb 20 2023, 11:47 AM

ashoat mentioned this in D6784: [keyserver] Fix rust-node-addon after deprecation of --experimental-specifier-resolution=node.

ashoat added a child revision: D6783: Update Prettier.Feb 20 2023, 11:47 AM

• jon accepted this revision.Feb 20 2023, 11:53 AM

This revision is now accepted and ready to land.Feb 20 2023, 11:53 AM

Harbormaster completed remote builds in B16629: Diff 22737.Feb 20 2023, 12:00 PM

atul accepted this revision.Feb 20 2023, 12:05 PM

Closed by commit rCOMM4adee5e8f27e: [native] Fix Buildkite iOS build to work from inside Nix (authored by ashoat). · Explain WhyFeb 20 2023, 12:25 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4adee5e8f27e: [native] Fix Buildkite iOS build to work from inside Nix.

[native] Fix Buildkite iOS build to work from inside Nix
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22740

.buildkite/ios.yml

native/package.json

postinstall.sh

[native] Fix Buildkite iOS build to work from inside NixClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22740

.buildkite/ios.yml

native/package.json

postinstall.sh

[native] Fix Buildkite iOS build to work from inside Nix
ClosedPublic
Actions

Revision Contents
Changeset List