Page MenuHomePhabricator

[native] Fix Buildkite iOS build to work from inside Nix
ClosedPublic

Authored by ashoat on Feb 20 2023, 10:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 5:02 PM
Unknown Object (File)
Mon, Jun 10, 4:38 AM
Unknown Object (File)
Thu, May 30, 1:59 AM
Unknown Object (File)
May 11 2024, 10:18 AM
Unknown Object (File)
May 11 2024, 10:18 AM
Unknown Object (File)
May 11 2024, 10:18 AM
Unknown Object (File)
May 11 2024, 12:08 AM
Unknown Object (File)
May 11 2024, 12:08 AM
Subscribers

Details

Summary

We need the same patch we use in native/package.json for yarn react-native and yarn expo.

Test Plan

Let's see if this diff's Buildkite build succeeds :)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fix_ios_buildkite
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Feb 20 2023, 10:50 AM

Move $PATH hack to package.json. I suspect Buildkite is doing something wonky

Seeing this issue because macOS's cp command is in /bin, and so we end up using the GNU one instead

This revision updates us to prefix $PATH with not just /usr/bin, but also /bin, so that we have access to BSD cp

It worked! Adding /bin to all of the places we prefix /usr/bin for future-proofing

This revision is now accepted and ready to land.Feb 20 2023, 11:53 AM