Page MenuHomePhabricator
Differential D6790

[Keyserver/rust-addon] Call identity deleteUser on account deletion
ClosedPublic
Actions

Authored by • jon on Feb 20 2023, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 12:05 PM
Unknown Object (File)
Fri, Apr 18, 4:15 PM
Unknown Object (File)
Fri, Apr 18, 12:20 PM
Unknown Object (File)
Fri, Apr 18, 9:05 AM
Unknown Object (File)
Fri, Apr 18, 8:41 AM
Unknown Object (File)
Fri, Apr 18, 8:23 AM
Unknown Object (File)
Fri, Apr 18, 3:31 AM
Unknown Object (File)
Thu, Apr 17, 12:18 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
varun
ashoat
Commits
rCOMMd33e4c4fba27: [Keyserver/rust-addon] Call identity deleteUser on account deletion
Summary

Integrate identity service's delete_user functionality
with Keyserver.

Part of https://linear.app/comm/issue/ENG-2764
Part of https://linear.app/comm/issue/ENG-2748

Depends on D6789

Test Plan
nix develop

comm-dev services start # start localstack

# Configure "aws" resources on localstack
(cd services/terraform && ./run.sh)

# start identity service and run mobile workflow
(cd services/identity && cargo run -- server &)
(cd keyserver && yarn dev &)
(cd native && yarn dev &)

(User exists in MySQL but not dynamodb use case)
Run either the iOS or Android client:

  • Create an account
  • Delete the account
  • Assert that the keyserver is still running, and identity service emits logs attempting to delete the user

(User exist in both MySQL and dynamodb)
Run either the iOS or Android client:

  • Create an account
  • Use TablePlus or other tool to find userID of your user
  • Seed a user:
    • aws dynamodb put-item --table-name identity-users --item '{"userID": {"S": "<USERID>"}}'
  • Verify user exists:
    • aws dynamodb get-item --table-name identity-users --key '{ "userID": {"S": "<USERID>"} }'
  • Delete account in App
  • Verify user has been deleted:
    • aws dynamodb get-item --table-name identity-users --key '{ "userID": {"S": "<USERID>"} }'

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Feb 20 2023, 1:58 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 20 2023, 1:58 PM
Harbormaster completed remote builds in B16644: Diff 22755.Feb 20 2023, 2:13 PM
• jon requested review of this revision.Feb 20 2023, 2:13 PM
ashoat added a comment.Feb 20 2023, 6:36 PM

Just a comment on the JS – won't request changes so that it stays on @varun's queue for the Rust side

keyserver/src/deleters/account-deleters.js
52

Instead of blocking execution here, we can call getRustAPI here and hold on to the promise

100

And then only block execution when we need to

varun accepted this revision.Feb 21 2023, 10:21 AM

rust part looks good! just make sure you address ashoat's comments before landing

This revision is now accepted and ready to land.Feb 21 2023, 10:21 AM
• jon updated this revision to Diff 22885.Feb 21 2023, 10:52 AM

Apply proto changes to keyserver addon

Harbormaster completed remote builds in B16730: Diff 22885.Feb 21 2023, 11:21 AM
• jon updated this revision to Diff 22891.Feb 21 2023, 11:56 AM

Apply JS promise feedback

ashoat accepted this revision.Feb 21 2023, 12:08 PM
Harbormaster completed remote builds in B16734: Diff 22891.Feb 21 2023, 12:11 PM
• jon marked 2 inline comments as done.Feb 21 2023, 1:21 PM
• jon updated this revision to Diff 22896.Feb 21 2023, 1:37 PM

Rebase on master

Harbormaster completed remote builds in B16739: Diff 22896.Feb 21 2023, 1:52 PM
Closed by commit rCOMMd33e4c4fba27: [Keyserver/rust-addon] Call identity deleteUser on account deletion (authored by • jon). · Explain WhyFeb 22 2023, 4:36 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMd33e4c4fba27: [Keyserver/rust-addon] Call identity deleteUser on account deletion.
• max mentioned this in D6690: [keyserver] Unifying API interface and adding Tunnelbroker types.Feb 23 2023, 8:27 AM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
5 lines
src/
38 lines
1 line
src/
deleters/
3 lines

Diff 22755

View Options

keyserver/addons/rust-node-addon/index.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

keyserver/addons/rust-node-addon/src/delete_user.rs

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

keyserver/addons/rust-node-addon/src/lib.rs

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

keyserver/src/deleters/account-deleters.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines