Page MenuHomePhabricator
Differential D6828

[web] Change "Sign in" button colors to match designs
ClosedPublic
Actions

Authored by atul on Feb 21 2023, 10:34 PM.
Tags
None
Referenced Files
F3740833: D6828.id22910.diff
Thu, Jan 9, 11:44 AM
Unknown Object (File)
Tue, Jan 7, 6:16 PM
Unknown Object (File)
Tue, Jan 7, 6:15 PM
Unknown Object (File)
Tue, Jan 7, 6:15 PM
Unknown Object (File)
Tue, Jan 7, 6:15 PM
Unknown Object (File)
Tue, Jan 7, 6:11 PM
Unknown Object (File)
Tue, Jan 7, 10:58 AM
Unknown Object (File)
Tue, Jan 7, 10:57 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
ginsu
rohan
Commits
rCOMM2b5cc9dbafc0: [web] Change "Sign in" button colors to match designs
Summary

We reverted the change that replaced the purple globally and opted for just changing it in SIWELoginForm and TraditionalLoginForm to match designs.

Context: We should be able to close the "SIWE on web" design task (https://linear.app/comm/issue/DES-23/siwe-on-web)

Test Plan

Looks as expected, can go through with David/Ted to make sure things look as expected.

f3a31d.png (1×2 px, 193 KB)

ecea08.png (1×2 px, 326 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6828 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 21 2023, 10:34 PM
atul published this revision for review.Feb 21 2023, 10:36 PM
ginsu accepted this revision.Feb 21 2023, 10:41 PM

Can't see the color change visually, but code looks good

This revision is now accepted and ready to land.Feb 21 2023, 10:41 PM
Harbormaster completed remote builds in B16750: Diff 22910.Feb 21 2023, 10:49 PM
atul edited the test plan for this revision. (Show Details)Feb 21 2023, 11:44 PM
In D6828#202931, @ginsu wrote:

Can't see the color change visually, but code looks good

Added screenshots to Test Plan

atul updated this revision to Diff 22917.Feb 22 2023, 12:25 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 22 2023, 12:27 AM
Closed by commit rCOMM2b5cc9dbafc0: [web] Change "Sign in" button colors to match designs (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM2b5cc9dbafc0: [web] Change "Sign in" button colors to match designs.
Harbormaster completed remote builds in B16757: Diff 22917.Feb 22 2023, 12:44 AM

Revision Contents
Changeset List

Diff 22917

View Options

web/account/siwe-login-form.react.js

Loading...
View Options

web/account/traditional-login-form.react.js

Loading...